Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(37)

Issue 149720043: code review 149720043: cmd/go: prohibit C sources files unless using cgo (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by rsc
Modified:
8 years, 2 months ago
Reviewers:
josharian, iant, bradfitz
CC:
iant, golang-codereviews, r
Visibility:
Public.

Description

cmd/go: prohibit C sources files unless using cgo Those C files would have been compiled with 6c. It's close to impossible to use C correctly anymore, and the C compilers are going away eventually. Make them unavailable now. go1.4.txt change in CL 145890046

Patch Set 1 #

Patch Set 2 : diff -r be1dc6653a56fba725eeb6e965e8d0510a0e2eb4 https://code.google.com/p/go/ #

Patch Set 3 : diff -r be1dc6653a56fba725eeb6e965e8d0510a0e2eb4 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 2f66d595a9ec50db3bf4fe871c6a25a5fff21df3 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -59 lines) Patch
M misc/cgo/test/backdoor/backdoor.go View 1 2 1 chunk +1 line, -2 lines 0 comments Download
R misc/cgo/test/backdoor/backdoor_gccgo.go View 1 2 1 chunk +0 lines, -11 lines 0 comments Download
R misc/cgo/test/backdoor/runtime.c View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
R misc/cgo/test/issue7695_test.go View 1 2 1 chunk +0 lines, -30 lines 0 comments Download
M src/cmd/go/pkg.go View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/cmd/go/test.bash View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
A src/cmd/go/testdata/src/badc/x.c View 1 2 1 chunk +1 line, -0 lines 0 comments Download
A src/cmd/go/testdata/src/badc/x.go View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/net/empty.s View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/runtime/debug/debug.s View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 7
rsc
Hello iant (cc: golang-codereviews@googlegroups.com, r), I'd like you to review this change to https://code.google.com/p/go/
8 years, 2 months ago (2014-09-19 03:50:52 UTC) #1
iant
LGTM
8 years, 2 months ago (2014-09-19 14:44:01 UTC) #2
rsc
*** Submitted as https://code.google.com/p/go/source/detail?r=19aadfae8426 *** cmd/go: prohibit C sources files unless using cgo Those C ...
8 years, 2 months ago (2014-09-24 19:10:44 UTC) #3
josharian
Build breakage emails appear to still be off. In lieu of that: This broke all ...
8 years, 2 months ago (2014-09-24 19:46:00 UTC) #4
bradfitz
On Wed, Sep 24, 2014 at 12:46 PM, <josharian@gmail.com> wrote: > Build breakage emails appear ...
8 years, 2 months ago (2014-09-24 20:00:36 UTC) #5
rsc
On Wed, Sep 24, 2014 at 4:00 PM, Brad Fitzpatrick <bradfitz@golang.org> wrote: > All the ...
8 years, 2 months ago (2014-09-24 21:38:23 UTC) #6
rsc
8 years, 2 months ago (2014-09-24 23:26:28 UTC) #7
Okay, I think most things are happy now. Stopping for tonight. If someone
wants to figure out why Plan 9 is unhappy go for it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b