https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.itely#newcode680 Documentation/usage/running.itely:680: @item @code{tags-to-keep} What do you think about @code{keep-with-tag} and ...
10 years, 7 months ago
(2014-10-09 06:36:16 UTC)
#1
On 2014/10/09 06:36:16, marc wrote: > https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.itely > File Documentation/usage/running.itely (right): > > https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.itely#newcode680 > ...
10 years, 7 months ago
(2014-10-09 06:58:06 UTC)
#2
On 2014/10/09 06:36:16, marc wrote:
>
https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.i...
> File Documentation/usage/running.itely (right):
>
>
https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.i...
> Documentation/usage/running.itely:680: @item @code{tags-to-keep}
> What do you think about
> @code{keep-with-tag} and @code{remove-with-tag}
> to match the corresponding @code{\keepWithTag} and @code{\removeWithTag}
> LilyPond commands?
>
> Giving similar functions different names would at least confuse myself as a
user
> ;-)
The reason I picked those names was basically that the list of options for
lilypond -dhelp
and in the Usage Reference is alphabetically sorted and I had to pick between
separating the options, abandoning the sorting order, or letting them start in a
similar way. So I thought this would likely be the lesser evil, but of course
that is entirely subjective and if we get enough feedback to be even closely
similar to a vote or statistical relevance, I'll be happy to change the choice.
The patch works as expected. However, it has to be noted that by default (that ...
10 years, 7 months ago
(2014-10-09 07:45:38 UTC)
#3
The patch works as expected.
However, it has to be noted that by default (that is, running without the
option) *keeps* the tags. When I define a command and encapsulate it in a tag
this command is executed unless explicitly switched off with -dtags-to-remove.
On 2014/10/09 07:45:38, uliska wrote: > The patch works as expected. > > However, it ...
10 years, 7 months ago
(2014-10-09 08:27:48 UTC)
#4
On 2014/10/09 07:45:38, uliska wrote:
> The patch works as expected.
>
> However, it has to be noted that by default (that is, running without the
> option) *keeps* the tags.
Sure. So does \keepWithTag #'() \tag hi { c4 4 4 4 } (actually, before the
existence of \tagGroup it didn't).
> When I define a command and encapsulate it in a tag
> this command is executed unless explicitly switched off with -dtags-to-remove.
Or unless you use -dtags-to-keep on a different tag. Yes.
You can check the options with (ly:get-option '...) and set them with
(ly:set-option '...) so you have the ability to push in an implicit
\keepWithTag #'score when nothing of other relevance is specified on the command
line.
If that is not good enough, the question is how this could be made better.
Issue 149650043: Implement -dtags-to-keep and -dtags-to-remove commandline options
Created 10 years, 7 months ago by dak
Modified 10 years, 7 months ago
Reviewers: marc, uliska
Base URL:
Comments: 1