Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1300)

Issue 149650043: Implement -dtags-to-keep and -dtags-to-remove commandline options

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 6 months ago by dak
Modified:
9 years, 6 months ago
Reviewers:
marc, uliska
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Implement -dtags-to-keep and -dtags-to-remove commandline options

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M Documentation/usage/running.itely View 1 chunk +10 lines, -0 lines 1 comment Download
M scm/lily.scm View 1 chunk +6 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 4
marc
https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.itely File Documentation/usage/running.itely (right): https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.itely#newcode680 Documentation/usage/running.itely:680: @item @code{tags-to-keep} What do you think about @code{keep-with-tag} and ...
9 years, 6 months ago (2014-10-09 06:36:16 UTC) #1
dak
On 2014/10/09 06:36:16, marc wrote: > https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.itely > File Documentation/usage/running.itely (right): > > https://codereview.appspot.com/149650043/diff/1/Documentation/usage/running.itely#newcode680 > ...
9 years, 6 months ago (2014-10-09 06:58:06 UTC) #2
uliska
The patch works as expected. However, it has to be noted that by default (that ...
9 years, 6 months ago (2014-10-09 07:45:38 UTC) #3
dak
9 years, 6 months ago (2014-10-09 08:27:48 UTC) #4
On 2014/10/09 07:45:38, uliska wrote:
> The patch works as expected.
> 
> However, it has to be noted that by default (that is, running without the
> option) *keeps* the tags.

Sure.  So does \keepWithTag #'() \tag hi { c4 4 4 4 } (actually, before the
existence of \tagGroup it didn't).


> When I define a command and encapsulate it in a tag
> this command is executed unless explicitly switched off with -dtags-to-remove.

Or unless you use -dtags-to-keep on a different tag.  Yes.

You can check the options with (ly:get-option '...) and set them with
(ly:set-option '...) so you have the ability to push in an implicit
\keepWithTag #'score when nothing of other relevance is specified on the command
line.

If that is not good enough, the question is how this could be made better.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b