Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1133)

Issue 14960044: Removal of the bottom landscape bar

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by rharding
Modified:
10 years, 7 months ago
Reviewers:
mp+191846, jeff.pihach
Visibility:
Public.

Description

Removal of the bottom landscape bar You will see the bottom bar has been removed from the dom with all connected commands. I did not move the controls as there was no direction too. Simply deleted them. Removed the element of the stylesheet that set the Charm Browser's bottom value and removed the SASS var with the height of the bottom bar. https://code.launchpad.net/~rharding/juju-gui/qa-ant-remove-bottom/+merge/191846 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -300 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/app.js View 5 chunks +1 line, -10 lines 0 comments Download
M app/modules-debug.js View 1 chunk +0 lines, -4 lines 0 comments Download
D app/templates/landscape-controls.partial View 1 chunk +0 lines, -17 lines 0 comments Download
M app/templates/overview.handlebars View 1 chunk +0 lines, -3 lines 0 comments Download
M app/views/environment.js View 2 chunks +0 lines, -2 lines 0 comments Download
M app/views/topology/bundle.js View 1 chunk +0 lines, -2 lines 0 comments Download
D app/views/topology/landscape.js View 1 chunk +0 lines, -73 lines 0 comments Download
M app/views/topology/service.js View 2 chunks +0 lines, -50 lines 1 comment Download
M app/views/topology/topology.js View 1 chunk +0 lines, -1 line 0 comments Download
M app/views/utils.js View 1 chunk +0 lines, -32 lines 0 comments Download
M lib/views/browser/main.less View 1 chunk +0 lines, -4 lines 0 comments Download
M lib/views/browser/vars.less View 1 chunk +0 lines, -1 line 0 comments Download
M test/test_environment_view.js View 1 chunk +0 lines, -39 lines 0 comments Download
M test/test_landscape.js View 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 2
rharding
Please take a look.
10 years, 7 months ago (2013-10-18 17:32:22 UTC) #1
jeff.pihach
10 years, 7 months ago (2013-10-18 18:08:21 UTC) #2
The removal looks good thanks for all the work! Before this lands I would like
to have a discussion as to what the long term goal of this removal and the
landscape integration is to see if we should save some of this code or remove
even more.

QA NOT OK
When viewing the browser in 'Browse' mode there is a white bar across the bottom
of the page.

There is a large white gap when viewing search results in 'Browse' mode: 
http://localhost:8888/fullscreen/search/?categories=app-servers&text=

Without the footer the url/status indicator in chrome covers part of the token
when hovering over the tokens.

https://codereview.appspot.com/14960044/diff/1/app/views/topology/service.js
File app/views/topology/service.js (left):

https://codereview.appspot.com/14960044/diff/1/app/views/topology/service.js#...
app/views/topology/service.js:183:
'/juju-ui/assets/images/landscape_restart_round.png';
These assets should probably be removed from the file system.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b