Issue 14960043: code review 14960043: leveldb: implement table cache.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14960043: code review 14960043: leveldb: implement table cache. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 1 month ago by nigeltao

Modified:
11 years, 1 month ago

Reviewers:
bradfitz

CC:
bradfitz, golang-dev

Visibility:
Public.

Patch Set 2 : diff -r 055c1dd8105d https://code.google.com/p/leveldb-go #

Patch Set 3 : diff -r 055c1dd8105d https://code.google.com/p/leveldb-go #

Total comments: 1

Patch Set 4 : diff -r 055c1dd8105d https://code.google.com/p/leveldb-go #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+449 lines, -32 lines)			Patch
M	leveldb/db/options.go	View	1	3 chunks	+14 lines, -0 lines	0 comments	Download
M	leveldb/leveldb.go	View	1 2 3	7 chunks	+19 lines, -12 lines	0 comments	Download
A	leveldb/table_cache.go	View	1	1 chunk	+175 lines, -0 lines	0 comments	Download
A	leveldb/table_cache_test.go	View	1 2 3	1 chunk	+224 lines, -0 lines	0 comments	Download
M	leveldb/version.go	View	1	6 chunks	+10 lines, -14 lines	0 comments	Download
M	leveldb/version_test.go	View	1	4 chunks	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bradfitz@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/leveldb-go

11 years, 1 month ago (2013-10-18 07:06:44 UTC) #1

bradfitz

LGTM https://codereview.appspot.com/14960043/diff/60001/leveldb/leveldb.go File leveldb/leveldb.go (right): https://codereview.appspot.com/14960043/diff/60001/leveldb/leveldb.go#newcode170 leveldb/leveldb.go:170: if err := d.fileLock.Close(); retErr != nil { ...

11 years, 1 month ago (2013-10-20 22:30:48 UTC) #2

nigeltao

11 years, 1 month ago (2013-10-22 03:24:46 UTC) #3

*** Submitted as
https://code.google.com/p/leveldb-go/source/detail?r=9962a12aab4f ***

leveldb: implement table cache.

R=bradfitz
CC=golang-dev
https://codereview.appspot.com/14960043

Expand All Messages | Collapse All Messages