Bundle topo preview fixes

Bundle topo preview fixes

Center bundle topo properly and size SVG to parent container.  This incidentally fixes what appeared to be a bug of non-promulgated charms not being displayed (was off the canvas).

https://code.launchpad.net/~makyo/juju-gui/bundle-zoomtofit/+merge/192363

(do not edit description out of merge proposal)

[matthew.scott, 2013-10-23 16:41:42]

Please take a look.

[gary.poster, 2013-10-23 17:10:13]

LGTM with trivials.  Would be nice to have a test of the getBoundingBox changes.
 Doing QA now.  Thank you!

https://codereview.appspot.com/14930052/diff/1/app/subapps/browser/views/bund...
File app/subapps/browser/views/bundle.js (right):

https://codereview.appspot.com/14930052/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:175: var options = {size: [720, 360]};
As we discussed, please check with Luca to see if he thinks we can increase the
height a bit.

https://codereview.appspot.com/14930052/diff/1/app/views/topology/bundle.js
File app/views/topology/bundle.js (right):

https://codereview.appspot.com/14930052/diff/1/app/views/topology/bundle.js#n...
app/views/topology/bundle.js:386: centroid[1] += 96 * scale;
It would be lovely to deduce 96.  Failing that, I think we ought to at least
document what it is supposed to be (perhaps by using a well-named "constant"
variable).

https://codereview.appspot.com/14930052/diff/1/app/views/topology/utils.js
File app/views/topology/utils.js (right):

https://codereview.appspot.com/14930052/diff/1/app/views/topology/utils.js#ne...
app/views/topology/utils.js:174: translateX: minX - boxWidth, translateY: minY -
boxHeight,
You said we don't use this, but we also agreed that boxHeight and boxWidth
should each be divided by 2.  Delete or fix. :-)

[gary.poster, 2013-10-23 17:21:55]

On 2013/10/23 17:10:13, gary.poster wrote:
> LGTM with trivials.  Would be nice to have a test of the getBoundingBox
changes.
>  Doing QA now.  Thank you!
> 
>
https://codereview.appspot.com/14930052/diff/1/app/subapps/browser/views/bund...
> File app/subapps/browser/views/bundle.js (right):
> 
>
https://codereview.appspot.com/14930052/diff/1/app/subapps/browser/views/bund...
> app/subapps/browser/views/bundle.js:175: var options = {size: [720, 360]};
> As we discussed, please check with Luca to see if he thinks we can increase
the
> height a bit.
> 
> https://codereview.appspot.com/14930052/diff/1/app/views/topology/bundle.js
> File app/views/topology/bundle.js (right):
> 
>
https://codereview.appspot.com/14930052/diff/1/app/views/topology/bundle.js#n...
> app/views/topology/bundle.js:386: centroid[1] += 96 * scale;
> It would be lovely to deduce 96.  Failing that, I think we ought to at least
> document what it is supposed to be (perhaps by using a well-named "constant"
> variable).
> 
> https://codereview.appspot.com/14930052/diff/1/app/views/topology/utils.js
> File app/views/topology/utils.js (right):
> 
>
https://codereview.appspot.com/14930052/diff/1/app/views/topology/utils.js#ne...
> app/views/topology/utils.js:174: translateX: minX - boxWidth, translateY: minY
-
> boxHeight,
> You said we don't use this, but we also agreed that boxHeight and boxWidth
> should each be divided by 2.  Delete or fix. :-)

QA good.  Thank you! This is a huge improvement, and we could launch with it if
needed, I think.  I look forward to proper centering in the future, if we can.

Gary

[matthew.scott, 2013-10-23 21:31:09]

Please take a look.

[gary.poster, 2013-10-24 04:05:15]

On 2013/10/23 21:31:09, matthew.scott wrote:
> Please take a look.

Looks even better, thank you.

If you could get this landed before tomorrow morning's demo that would be nice,
but if not, no worries. :-)

[matthew.scott, 2013-10-24 15:55:05]

*** Submitted:

Bundle topo preview fixes

Center bundle topo properly and size SVG to parent container.  This incidentally
fixes what appeared to be a bug of non-promulgated charms not being displayed
(was off the canvas).

R=gary.poster
CC=
https://codereview.appspot.com/14930052