Issue 14930050: code review 14930050: freetype/truetype: implement SPVTL, SFVTL, SHZ, SHPIX o...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14930050: code review 14930050: freetype/truetype: implement SPVTL, SFVTL, SHZ, SHPIX o... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 2 months ago by nigeltao

Modified:
11 years, 2 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-dev, remyoudompheng

Visibility:
Public.

Description

freetype/truetype: implement SPVTL, SFVTL, SHZ, SHPIX opcodes. Fix MIRP opcodes, scaled CVT initialization and Hinter.move.

Patch Set 2 : diff -r 0bd12cbef314 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 0bd12cbef314 https://code.google.com/p/freetype-go #

Total comments: 2

Patch Set 4 : diff -r 0bd12cbef314 https://code.google.com/p/freetype-go #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+213 lines, -54 lines)			Patch
M	freetype/truetype/hint.go	View	1 2 3	19 chunks	+143 lines, -44 lines	0 comments	Download
M	freetype/truetype/hint_test.go	View	1	1 chunk	+60 lines, -0 lines	0 comments	Download
M	freetype/truetype/opcodes.go	View	1	3 chunks	+9 lines, -9 lines	0 comments	Download
M	freetype/truetype/truetype_test.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com, remyoudompheng@gmail.com), I'd like you to review this change to https://code.google.com/p/freetype-go

11 years, 2 months ago (2013-10-23 08:18:40 UTC) #1

bsiegert

LGTM modulo the comments below https://codereview.appspot.com/14930050/diff/50001/freetype/truetype/hint.go File freetype/truetype/hint.go (right): https://codereview.appspot.com/14930050/diff/50001/freetype/truetype/hint.go#newcode1164 freetype/truetype/hint.go:1164: if denom < 0 ...

11 years, 2 months ago (2013-10-23 11:43:32 UTC) #2

nigeltao

11 years, 2 months ago (2013-10-23 23:48:02 UTC) #3

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=4289d0d71a69 ***

freetype/truetype: implement SPVTL, SFVTL, SHZ, SHPIX opcodes.

Fix MIRP opcodes, scaled CVT initialization and Hinter.move.

R=bsiegert
CC=golang-dev, remyoudompheng
https://codereview.appspot.com/14930050

Expand All Messages | Collapse All Messages