Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2989)

Issue 14930049: Enable running live tests against any EC2 region

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by gz
Modified:
10 years, 6 months ago
Reviewers:
mp+192269
Visibility:
Public.

Description

Enable running live tests against any EC2 region There are two stages: * Making the test -amazon flag take a region name * Looking up real amis with simplestreams and using those in tests Perhaps leaving the -amazon flag as an enabling bool, and setting a new flag just for selecting a region that defaults to us-east-1 would be better. Both the simplestreams code and required test changes are pretty ugly, a bigger rewrite would help to clean up the tests. https://code.launchpad.net/~gz/goamz/tests_amazon_region/+merge/192269 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Enable running live tests against any EC2 region #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -29 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ec2/ec2_test.go View 1 1 chunk +7 lines, -7 lines 0 comments Download
M ec2/ec2i_test.go View 1 2 chunks +17 lines, -7 lines 0 comments Download
M ec2/ec2t_test.go View 1 8 chunks +21 lines, -9 lines 0 comments Download
M ec2/ec2test/server.go View 1 1 chunk +1 line, -1 line 0 comments Download
A testutil/streams.go View 1 1 chunk +91 lines, -0 lines 0 comments Download
A testutil/streams_test.go View 1 1 chunk +150 lines, -0 lines 0 comments Download
M testutil/suite.go View 2 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 2
gz
Please take a look.
10 years, 6 months ago (2013-10-23 00:06:10 UTC) #1
gz
10 years, 6 months ago (2013-10-24 00:16:47 UTC) #2
Please take a look.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b