Issue 14870046: code review 14870046: cmd/cgo: fix line number in an error message

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14870046: code review 14870046: cmd/cgo: fix line number in an error message (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by rsc

Modified:
10 years, 6 months ago

Reviewers:
iant

CC:
golang-dev, iant

Visibility:
Public.

Description

cmd/cgo: fix line number in an error message Fixes issue 6563.

Patch Set 1 #

Patch Set 2 : diff -r 90a628ac54ed https://code.google.com/p/go/ #

Patch Set 3 : diff -r 90a628ac54ed https://code.google.com/p/go/ #

Patch Set 4 : diff -r 90a628ac54ed https://code.google.com/p/go/ #

Patch Set 5 : diff -r 90a628ac54ed https://code.google.com/p/go/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -15 lines)			Patch
M	misc/cgo/errors/err1.go	View	1 2	1 chunk	+5 lines, -1 line	0 comments	Download
A	misc/cgo/errors/err2.go	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	misc/cgo/errors/test.bash	View	1 2 3	1 chunk	+25 lines, -13 lines	0 comments	Download
M	src/cmd/cgo/gcc.go	View	1 2 3 4	2 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

10 years, 6 months ago (2013-10-18 20:00:23 UTC) #1

rsc

10 years, 6 months ago (2013-10-18 20:52:47 UTC) #5

*** Submitted as https://code.google.com/p/go/source/detail?r=b508daf6dae6 ***

cmd/cgo: fix line number in an error message

Fixes issue 6563.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/14870046

Expand All Messages | Collapse All Messages