code review 14860043: api: add go1.2.txt, use in tests

api: add go1.2.txt, use in tests

[adg, 2013-10-18 03:01:50]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[adg, 2013-10-18 03:03:46]

the go1.2.txt was too big for mail, see attached


On 18 October 2013 12:01, <adg@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://code.google.com/p/go
>
>
> Description:
> api: add go1.2.txt, use in tests
>
> Please review this at
https://codereview.appspot.**com/14860043/<https://codereview.appspot.com/148...
>
> Affected files (+1, -1 lines):
>   M src/cmd/api/run.go
>
>
>

[adg, 2013-10-18 03:05:12]

Here are the additions, minus log/syslog and syscall:

pkg archive/zip, func RegisterCompressor(uint16, Compressor)
pkg archive/zip, func RegisterDecompressor(uint16, Decompressor)
pkg archive/zip, method (*File) DataOffset() (int64, error)
pkg archive/zip, type Compressor func(io.Writer) (io.WriteCloser, error)
pkg archive/zip, type Decompressor func(io.Reader) io.ReadCloser
pkg bufio, method (*Reader) Reset(io.Reader)
pkg bufio, method (*Writer) Reset(io.Writer)
pkg compress/flate, method (*Writer) Reset(io.Writer)
pkg compress/gzip, method (*Writer) Reset(io.Writer)
pkg compress/zlib, method (*Writer) Reset(io.Writer)
pkg container/heap, func Fix(Interface, int)
pkg container/list, method (*List) MoveAfter(*Element, *Element)
pkg container/list, method (*List) MoveBefore(*Element, *Element)
pkg crypto, type PublicKey interface {}
pkg crypto/cipher, func NewGCM(Block) (AEAD, error)
pkg crypto/cipher, type AEAD interface { NonceSize, Open, Overhead, Seal }
pkg crypto/cipher, type AEAD interface, NonceSize() int
pkg crypto/cipher, type AEAD interface, Open([]uint8, []uint8, []uint8,
[]uint8) ([]uint8, error)
pkg crypto/cipher, type AEAD interface, Overhead() int
pkg crypto/cipher, type AEAD interface, Seal([]uint8, []uint8, []uint8,
[]uint8) []uint8
pkg crypto/md5, func Sum([]uint8) [16]uint8
pkg crypto/rsa, const PSSSaltLengthAuto = 0
pkg crypto/rsa, const PSSSaltLengthAuto ideal-int
pkg crypto/rsa, const PSSSaltLengthEqualsHash = -1
pkg crypto/rsa, const PSSSaltLengthEqualsHash ideal-int
pkg crypto/rsa, func SignPSS(io.Reader, *PrivateKey, crypto.Hash, []uint8,
*PSSOptions) ([]uint8, error)
pkg crypto/rsa, func VerifyPSS(*PublicKey, crypto.Hash, []uint8, []uint8,
*PSSOptions) error
pkg crypto/rsa, type PSSOptions struct
pkg crypto/rsa, type PSSOptions struct, SaltLength int
pkg crypto/sha1, func Sum([]uint8) [20]uint8
pkg crypto/sha256, func Sum224([]uint8) [28]uint8
pkg crypto/sha256, func Sum256([]uint8) [32]uint8
pkg crypto/sha512, func Sum384([]uint8) [48]uint8
pkg crypto/sha512, func Sum512([]uint8) [64]uint8
pkg crypto/subtle, func ConstantTimeLessOrEq(int, int) int
pkg crypto/tls, const TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA = 49161
pkg crypto/tls, const TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA uint16
pkg crypto/tls, const TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 = 49195
pkg crypto/tls, const TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256 uint16
pkg crypto/tls, const TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA = 49162
pkg crypto/tls, const TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA uint16
pkg crypto/tls, const TLS_ECDHE_ECDSA_WITH_RC4_128_SHA = 49159
pkg crypto/tls, const TLS_ECDHE_ECDSA_WITH_RC4_128_SHA uint16
pkg crypto/tls, const TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 = 49199
pkg crypto/tls, const TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 uint16
pkg crypto/tls, const VersionSSL30 = 768
pkg crypto/tls, const VersionSSL30 ideal-int
pkg crypto/tls, const VersionTLS10 = 769
pkg crypto/tls, const VersionTLS10 ideal-int
pkg crypto/tls, const VersionTLS11 = 770
pkg crypto/tls, const VersionTLS11 ideal-int
pkg crypto/tls, const VersionTLS12 = 771
pkg crypto/tls, const VersionTLS12 ideal-int
pkg crypto/tls, type Config struct, MaxVersion uint16
pkg crypto/tls, type Config struct, MinVersion uint16
pkg crypto/x509, func MarshalECPrivateKey(*ecdsa.PrivateKey) ([]uint8,
error)
pkg crypto/x509, type Certificate struct, CRLDistributionPoints []string
pkg crypto/x509, type Certificate struct, Extensions []pkix.Extension
pkg crypto/x509, type Certificate struct, ExtraExtensions []pkix.Extension
pkg crypto/x509, type Certificate struct, IssuingCertificateURL []string
pkg crypto/x509, type Certificate struct, OCSPServer []string
pkg database/sql, method (*DB) SetMaxOpenConns(int)
pkg encoding, type BinaryMarshaler interface { MarshalBinary }
pkg encoding, type BinaryMarshaler interface, MarshalBinary() ([]uint8,
error)
pkg encoding, type BinaryUnmarshaler interface { UnmarshalBinary }
pkg encoding, type BinaryUnmarshaler interface, UnmarshalBinary([]uint8)
error
pkg encoding, type TextMarshaler interface { MarshalText }
pkg encoding, type TextMarshaler interface, MarshalText() ([]uint8, error)
pkg encoding, type TextUnmarshaler interface { UnmarshalText }
pkg encoding, type TextUnmarshaler interface, UnmarshalText([]uint8) error
pkg encoding/xml, method (*Encoder) EncodeElement(interface{},
StartElement) error
pkg encoding/xml, method (*Encoder) EncodeToken(Token) error
pkg encoding/xml, method (*Encoder) Flush() error
pkg encoding/xml, method (StartElement) End() EndElement
pkg encoding/xml, type Marshaler interface { MarshalXML }
pkg encoding/xml, type Marshaler interface, MarshalXML(*Encoder,
StartElement) error
pkg encoding/xml, type MarshalerAttr interface { MarshalXMLAttr }
pkg encoding/xml, type MarshalerAttr interface, MarshalXMLAttr(Name) (Attr,
error)
pkg encoding/xml, type Unmarshaler interface { UnmarshalXML }
pkg encoding/xml, type Unmarshaler interface, UnmarshalXML(*Decoder,
StartElement) error
pkg encoding/xml, type UnmarshalerAttr interface { UnmarshalXMLAttr }
pkg encoding/xml, type UnmarshalerAttr interface, UnmarshalXMLAttr(Attr)
error
pkg flag, type Getter interface { Get, Set, String }
pkg flag, type Getter interface, Get() interface{}
pkg flag, type Getter interface, Set(string) error
pkg flag, type Getter interface, String() string
pkg flag, var CommandLine *FlagSet
pkg go/ast, type SliceExpr struct, Max Expr
pkg go/ast, type SliceExpr struct, Slice3 bool
pkg go/ast, type TypeAssertExpr struct, Lparen token.Pos
pkg go/ast, type TypeAssertExpr struct, Rparen token.Pos
pkg go/build, method (*Context) MatchFile(string, string) (bool, error)
pkg go/build, type Package struct, AllTags []string
pkg go/build, type Package struct, CXXFiles []string
pkg go/build, type Package struct, CgoCPPFLAGS []string
pkg go/build, type Package struct, CgoCXXFLAGS []string
pkg go/build, type Package struct, ConflictDir string
pkg go/token, method (*File) MergeLine(int)
pkg html/template, type Template struct, Tree *parse.Tree
pkg image/color/palette, var Plan9 []color.Color
pkg image/color/palette, var WebSafe []color.Color
pkg image/draw, method (Op) Draw(Image, image.Rectangle, image.Image,
image.Point)
pkg image/draw, type Drawer interface { Draw }
pkg image/draw, type Drawer interface, Draw(Image, image.Rectangle,
image.Image, image.Point)
pkg image/draw, type Quantizer interface { Quantize }
pkg image/draw, type Quantizer interface, Quantize(color.Palette,
image.Image) color.Palette
pkg image/draw, var FloydSteinberg Drawer
pkg image/gif, func Encode(io.Writer, image.Image, *Options) error
pkg image/gif, func EncodeAll(io.Writer, *GIF) error
pkg image/gif, type Options struct
pkg image/gif, type Options struct, Drawer draw.Drawer
pkg image/gif, type Options struct, NumColors int
pkg image/gif, type Options struct, Quantizer draw.Quantizer
pkg net, method (*IP) UnmarshalText([]uint8) error
pkg net, method (*TCPConn) SetKeepAlivePeriod(time.Duration) error
pkg net, method (IP) MarshalText() ([]uint8, error)
pkg net, type Dialer struct, DualStack bool
pkg net/smtp, method (*Client) Close() error
pkg os (linux-arm), const O_SYNC = 1052672
pkg os (linux-arm-cgo), const O_SYNC = 1052672
pkg reflect, method (Value) SetCap(int)
pkg reflect, method (Value) Slice3(int, int, int) Value
pkg runtime, type MemStats struct, GCSys uint64
pkg runtime, type MemStats struct, OtherSys uint64
pkg runtime/debug, func SetMaxStack(int) int
pkg runtime/debug, func SetMaxThreads(int) int
pkg sort, func Stable(Interface)
pkg strings, func IndexByte(string, uint8) int
pkg sync/atomic, func SwapInt32(*int32, int32) int32
pkg sync/atomic, func SwapInt64(*int64, int64) int64
pkg sync/atomic, func SwapPointer(*unsafe.Pointer, unsafe.Pointer)
unsafe.Pointer
pkg sync/atomic, func SwapUint32(*uint32, uint32) uint32
pkg sync/atomic, func SwapUint64(*uint64, uint64) uint64
pkg sync/atomic, func SwapUintptr(*uintptr, uintptr) uintptr
pkg testing, func RegisterCover(Cover)
pkg testing, type Cover struct
pkg testing, type Cover struct, Blocks map[string][]CoverBlock
pkg testing, type Cover struct, Counters map[string][]uint32
pkg testing, type Cover struct, CoveredPackages string
pkg testing, type Cover struct, Mode string
pkg testing, type CoverBlock struct
pkg testing, type CoverBlock struct, Col0 uint16
pkg testing, type CoverBlock struct, Col1 uint16
pkg testing, type CoverBlock struct, Line0 uint32
pkg testing, type CoverBlock struct, Line1 uint32
pkg testing, type CoverBlock struct, Stmts uint16
pkg testing, type TB interface, Error(...interface{})
pkg testing, type TB interface, Errorf(string, ...interface{})
pkg testing, type TB interface, Fail()
pkg testing, type TB interface, FailNow()
pkg testing, type TB interface, Failed() bool
pkg testing, type TB interface, Fatal(...interface{})
pkg testing, type TB interface, Fatalf(string, ...interface{})
pkg testing, type TB interface, Log(...interface{})
pkg testing, type TB interface, Logf(string, ...interface{})
pkg testing, type TB interface, Skip(...interface{})
pkg testing, type TB interface, SkipNow()
pkg testing, type TB interface, Skipf(string, ...interface{})
pkg testing, type TB interface, Skipped() bool
pkg testing, type TB interface, unexported methods
pkg text/template, method (Template) Copy() *parse.Tree
pkg text/template/parse, method (*Tree) Copy() *Tree
pkg time, method (*Time) UnmarshalBinary([]uint8) error
pkg time, method (*Time) UnmarshalText([]uint8) error
pkg time, method (Time) MarshalBinary() ([]uint8, error)
pkg time, method (Time) MarshalText() ([]uint8, error)
pkg unicode, func In(int32, ...*RangeTable) bool

[iant, 2013-10-18 04:02:42]

LGTM

On Thu, Oct 17, 2013 at 8:04 PM, Andrew Gerrand <adg@golang.org> wrote:
> Here are the additions, minus log/syslog and syscall:


> pkg os (linux-arm), const O_SYNC = 1052672
> pkg os (linux-arm-cgo), const O_SYNC = 1052672

Note that these are changes, not additions, as discussed previously.


> pkg testing, func RegisterCover(Cover)
> pkg testing, type Cover struct
> pkg testing, type Cover struct, Blocks map[string][]CoverBlock
> pkg testing, type Cover struct, Counters map[string][]uint32
> pkg testing, type Cover struct, CoveredPackages string
> pkg testing, type Cover struct, Mode string
> pkg testing, type CoverBlock struct
> pkg testing, type CoverBlock struct, Col0 uint16
> pkg testing, type CoverBlock struct, Col1 uint16
> pkg testing, type CoverBlock struct, Line0 uint32
> pkg testing, type CoverBlock struct, Line1 uint32
> pkg testing, type CoverBlock struct, Stmts uint16

These are all marked as not covered by the Go 1 compatibility
guarantee.  I just want to mention that in case we want to think about
excluding some symbols from the api tool.  It may not be worth
worrying about.

Ian

[adg, 2013-10-18 04:37:15]

*** Submitted as https://code.google.com/p/go/source/detail?r=e2e0547ad087 ***

api: add go1.2.txt, use in tests

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/14860043