Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3022)

Issue 14804043: code review 14804043: all: new and updated APIs (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by bradfitz
Modified:
10 years, 7 months ago
Reviewers:
rsc
CC:
golang-dev
Visibility:
Public.

Description

all: new and updated APIs

Patch Set 1 #

Patch Set 2 : diff -r e34be2a3a660 https://code.google.com/p/google-api-go-client/ #

Patch Set 3 : diff -r e34be2a3a660 https://code.google.com/p/google-api-go-client/ #

Patch Set 4 : diff -r e34be2a3a660 https://code.google.com/p/google-api-go-client/ #

Patch Set 5 : diff -r e34be2a3a660 https://code.google.com/p/google-api-go-client/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42898 lines, -2995 lines) Patch
M adexchangebuyer/v1.1/adexchangebuyer-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M adexchangebuyer/v1.2/adexchangebuyer-api.json View 1 2 3 4 6 chunks +81 lines, -20 lines 0 comments Download
M adexchangebuyer/v1.2/adexchangebuyer-gen.go View 1 2 3 4 7 chunks +86 lines, -13 lines 0 comments Download
M adexchangebuyer/v1.3/adexchangebuyer-api.json View 1 2 3 4 8 chunks +111 lines, -21 lines 0 comments Download
M adexchangebuyer/v1.3/adexchangebuyer-gen.go View 1 2 3 4 10 chunks +113 lines, -15 lines 0 comments Download
M adexchangebuyer/v1/adexchangebuyer-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
A adexchangeseller/v1.1/adexchangeseller-api.json View 1 2 3 4 1 chunk +1240 lines, -0 lines 0 comments Download
A adexchangeseller/v1.1/adexchangeseller-gen.go View 1 2 3 4 1 chunk +2166 lines, -0 lines 0 comments Download
M adexchangeseller/v1/adexchangeseller-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M admin/directory_v1/admin-api.json View 1 2 3 4 17 chunks +66 lines, -2 lines 0 comments Download
M admin/directory_v1/admin-gen.go View 1 2 3 4 17 chunks +50 lines, -2 lines 0 comments Download
M admin/email_migration_v2/admin-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M admin/reports_v1/admin-api.json View 1 2 3 4 11 chunks +52 lines, -15 lines 0 comments Download
M admin/reports_v1/admin-gen.go View 1 2 3 4 9 chunks +22 lines, -4 lines 0 comments Download
M adsense/v1.2/adsense-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M adsense/v1.3/adsense-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M adsensehost/v4.1/adsensehost-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M analytics/v2.4/analytics-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M analytics/v3/analytics-api.json View 1 2 3 4 43 chunks +1646 lines, -36 lines 0 comments Download
M analytics/v3/analytics-gen.go View 1 2 3 4 52 chunks +3141 lines, -23 lines 0 comments Download
M androidpublisher/v1.1/androidpublisher-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M androidpublisher/v1/androidpublisher-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M appstate/v1/appstate-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M audit/v1/audit-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M bigquery/v2/bigquery-api.json View 1 2 3 4 16 chunks +140 lines, -17 lines 0 comments Download
M bigquery/v2/bigquery-gen.go View 1 2 3 4 20 chunks +209 lines, -49 lines 0 comments Download
M blogger/v2/blogger-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M blogger/v3/blogger-api.json View 1 2 3 4 27 chunks +931 lines, -14 lines 0 comments Download
M blogger/v3/blogger-gen.go View 1 2 3 4 50 chunks +1851 lines, -11 lines 0 comments Download
M books/v1/books-api.json View 1 2 3 4 3 chunks +20 lines, -2 lines 0 comments Download
M books/v1/books-gen.go View 1 2 3 4 4 chunks +31 lines, -0 lines 0 comments Download
M calendar/v3/calendar-api.json View 1 2 3 4 4 chunks +4 lines, -5 lines 0 comments Download
M calendar/v3/calendar-gen.go View 1 2 3 4 2 chunks +4 lines, -3 lines 0 comments Download
M civicinfo/us_v1/civicinfo-api.json View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M civicinfo/us_v1/civicinfo-gen.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M compute/v1beta15/compute-api.json View 1 2 3 4 9 chunks +74 lines, -5 lines 0 comments Download
M compute/v1beta15/compute-gen.go View 1 2 3 4 8 chunks +167 lines, -1 line 0 comments Download
A compute/v1beta16/compute-api.json View 1 2 3 4 1 chunk +6759 lines, -0 lines 0 comments Download
A compute/v1beta16/compute-gen.go View 1 2 3 4 1 chunk +10780 lines, -0 lines 0 comments Download
M coordinate/v1/coordinate-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M customsearch/v1/customsearch-api.json View 1 2 3 4 3 chunks +7 lines, -2 lines 0 comments Download
M customsearch/v1/customsearch-gen.go View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M datastore/v1beta1/datastore-api.json View 1 2 3 4 10 chunks +13 lines, -4 lines 0 comments Download
M datastore/v1beta1/datastore-gen.go View 1 2 3 4 9 chunks +12 lines, -3 lines 0 comments Download
A datastore/v1beta2/datastore-api.json View 1 2 3 4 1 chunk +1043 lines, -0 lines 0 comments Download
A datastore/v1beta2/datastore-gen.go View 1 2 3 4 1 chunk +1001 lines, -0 lines 0 comments Download
M dfareporting/v1.1/dfareporting-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M dfareporting/v1.2/dfareporting-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M dfareporting/v1.3/dfareporting-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M dfareporting/v1/dfareporting-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M discovery/v1/discovery-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M doubleclickbidmanager/v1/doubleclickbidmanager-api.json View 1 2 3 4 13 chunks +189 lines, -8 lines 0 comments Download
M doubleclickbidmanager/v1/doubleclickbidmanager-gen.go View 1 2 3 4 7 chunks +204 lines, -2 lines 0 comments Download
A doubleclicksearch/v2/doubleclicksearch-api.json View 1 2 3 4 1 chunk +803 lines, -0 lines 0 comments Download
A doubleclicksearch/v2/doubleclicksearch-gen.go View 1 2 3 4 1 chunk +1096 lines, -0 lines 0 comments Download
M drive/v1/drive-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M drive/v2/drive-api.json View 1 2 3 4 3 chunks +45 lines, -3 lines 0 comments Download
M drive/v2/drive-gen.go View 1 2 3 4 2 chunks +112 lines, -1 line 0 comments Download
M freebase/v1-sandbox/freebase-api.json View 1 2 3 4 3 chunks +280 lines, -139 lines 0 comments Download
M freebase/v1-sandbox/freebase-gen.go View 1 2 3 4 6 chunks +517 lines, -311 lines 0 comments Download
M freebase/v1/freebase-api.json View 1 2 3 4 3 chunks +252 lines, -372 lines 0 comments Download
M freebase/v1/freebase-gen.go View 1 2 3 4 5 chunks +486 lines, -651 lines 0 comments Download
M freebase/v1sandbox/freebase-api.json View 1 2 3 4 3 chunks +252 lines, -372 lines 0 comments Download
M freebase/v1sandbox/freebase-gen.go View 1 2 3 4 5 chunks +486 lines, -651 lines 0 comments Download
M games/v1/games-api.json View 1 2 3 4 31 chunks +34 lines, -8 lines 0 comments Download
M games/v1/games-gen.go View 1 2 3 4 32 chunks +40 lines, -11 lines 0 comments Download
M gamesmanagement/v1management/gamesmanagement-api.json View 1 2 3 4 9 chunks +12 lines, -3 lines 0 comments Download
M gamesmanagement/v1management/gamesmanagement-gen.go View 1 2 3 4 8 chunks +11 lines, -2 lines 0 comments Download
M gan/v1beta1/gan-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M gan/v1beta1/gan-gen.go View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M groupsmigration/v1/groupsmigration-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M groupssettings/v1/groupssettings-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M identitytoolkit/v3/identitytoolkit-api.json View 1 2 3 4 11 chunks +95 lines, -7 lines 0 comments Download
M identitytoolkit/v3/identitytoolkit-gen.go View 1 2 3 4 10 chunks +115 lines, -3 lines 0 comments Download
M licensing/v1/licensing-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M mirror/v1/mirror-api.json View 1 2 3 4 8 chunks +13 lines, -14 lines 0 comments Download
M mirror/v1/mirror-gen.go View 1 2 3 4 7 chunks +23 lines, -12 lines 0 comments Download
M oauth2/v1/oauth2-api.json View 1 2 3 4 3 chunks +2 lines, -7 lines 0 comments Download
M oauth2/v1/oauth2-gen.go View 1 2 3 4 2 chunks +1 line, -5 lines 0 comments Download
M oauth2/v2/oauth2-api.json View 1 2 3 4 3 chunks +2 lines, -7 lines 0 comments Download
M oauth2/v2/oauth2-gen.go View 1 2 3 4 2 chunks +1 line, -5 lines 0 comments Download
M orkut/v2/orkut-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M pagespeedonline/v1/pagespeedonline-api.json View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M pagespeedonline/v1/pagespeedonline-gen.go View 1 2 3 4 3 chunks +16 lines, -0 lines 0 comments Download
M plus/v1/plus-api.json View 1 2 3 4 5 chunks +4 lines, -9 lines 0 comments Download
M plus/v1/plus-gen.go View 1 2 3 4 4 chunks +3 lines, -7 lines 0 comments Download
A plusdomains/v1/plusdomains-api.json View 1 2 3 4 1 chunk +2102 lines, -0 lines 0 comments Download
A plusdomains/v1/plusdomains-gen.go View 1 2 3 4 1 chunk +3029 lines, -0 lines 0 comments Download
M prediction/v1.2/prediction-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M prediction/v1.3/prediction-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M prediction/v1.4/prediction-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M prediction/v1.5/prediction-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M reseller/v1/reseller-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M reseller/v1sandbox/reseller-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M shopping/v1/shopping-api.json View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M shopping/v1/shopping-gen.go View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M siteverification/v1/siteverification-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M sqladmin/v1beta1/sqladmin-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M storage/v1beta1/storage-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M storage/v1beta2/storage-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M taskqueue/v1beta1/taskqueue-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M taskqueue/v1beta2/taskqueue-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M tasks/v1/tasks-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M translate/v2/translate-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M urlshortener/v1/urlshortener-api.json View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M webfonts/v1/webfonts-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M youtube/v3/youtube-api.json View 1 2 3 4 29 chunks +314 lines, -16 lines 0 comments Download
M youtube/v3/youtube-gen.go View 1 2 3 4 40 chunks +476 lines, -5 lines 0 comments Download
M youtubeanalytics/v1/youtubeanalytics-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M youtubeanalytics/v1beta1/youtubeanalytics-api.json View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4
bradfitz
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/google-api-go-client/
10 years, 7 months ago (2013-10-17 21:48:02 UTC) #1
bradfitz
*** Submitted as https://code.google.com/p/google-api-go-client/source/detail?r=a5bd9c1fdc8c *** all: new and updated APIs R=golang-dev CC=golang-dev https://codereview.appspot.com/14804043
10 years, 7 months ago (2013-10-17 21:53:15 UTC) #2
bradfitz
$ time hg submit 14804043 ... Uploading patch for drive/v2/drive-api.json Uploading patch for drive/v2/drive-gen.go Uploading ...
10 years, 7 months ago (2013-10-17 21:54:18 UTC) #3
rsc
10 years, 7 months ago (2013-10-18 20:42:20 UTC) #4
codereview.appspot.com should be changed to allow bulk uploads (say, a zip
of the files), which would result in a single datastore op instead of many,
and codereview.py should be changed to use the new API. Neither has
happened.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b