Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1705)

Issue 147860043: Changes.tely updated - 2.19.x up to September 2014 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by pkx166h
Modified:
2 years, 3 months ago
Reviewers:
ht, dak, marc, Jean-Charles
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4122 Since June 2014. Added Tracker issues 2813/3966, 3734/3825/3834, 4015, 4022, 4038, 4042, 4047, 4056, 4063, 4083, and 4097. Included @lilypond examples where appropriate

Patch Set 1 #

Total comments: 25

Patch Set 2 : Corrections as per Marc H, David K and Jean-Charles M. #

Patch Set 3 : Updated commit message to tracker numbers removed from the initial patch. Minor TexInfo layout re-f… #

Patch Set 4 : Make the code make. Sheesh... talk about sloppy! #

Total comments: 2

Patch Set 5 : With Heikki T's comments #

Patch Set 6 : trying to fix doc compile issues #

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -0 lines) Patch
M Documentation/changes.tely View 1 2 3 4 5 1 chunk +104 lines, -0 lines 0 comments Download

Messages

Total messages: 15
pkx166h
Hello, if those that have put in these recent features and enhancements that are listed ...
4 years, 9 months ago (2014-09-21 09:36:50 UTC) #1
dak
https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode69 Documentation/changes.tely:69: \once \override ChorName.text = #"foo" ChordName.text Maybe make this ...
4 years, 9 months ago (2014-09-21 09:59:38 UTC) #2
Jean-Charles
https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode127 Documentation/changes.tely:127: the existing @code{\keepWithTag} and @code{removeWithTag} commands. For @code{\keepWithTag} and ...
4 years, 9 months ago (2014-09-21 10:00:06 UTC) #3
marc
Just some minor nitpicks, as I cannot speak about the details of the recent changes. ...
4 years, 9 months ago (2014-09-21 10:20:40 UTC) #4
pkx166h
Corrections as per Marc H, David K and Jean-Charles M.
4 years, 9 months ago (2014-09-21 20:44:47 UTC) #5
pkx166h
Updated commit message to tracker numbers removed from the initial patch. Minor TexInfo layout re-formatting.
4 years, 9 months ago (2014-09-21 20:52:30 UTC) #6
pkx166h
Thanks to those that checked. New patch uploaded https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode69 Documentation/changes.tely:69: \once ...
4 years, 9 months ago (2014-09-21 20:53:12 UTC) #7
pkx166h
Make the code make. Sheesh... talk about sloppy!
4 years, 9 months ago (2014-09-21 21:49:10 UTC) #8
marc
https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#newcode106 Documentation/changes.tely:106: grob can now be aligned on the @q{center} of ...
4 years, 9 months ago (2014-09-22 06:42:42 UTC) #9
ht
https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tely#newcode104 Documentation/changes.tely:104: @end example Just a small note: While this example ...
4 years, 9 months ago (2014-09-22 18:19:52 UTC) #10
pkx166h
With Heikki T's comments
4 years, 9 months ago (2014-09-23 17:26:27 UTC) #11
pkx166h
trying to fix doc compile issues
4 years, 9 months ago (2014-09-23 19:16:15 UTC) #12
pkx166h
https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tely#newcode104 Documentation/changes.tely:104: @end example On 2014/09/22 18:19:52, ht wrote: > Just ...
4 years, 9 months ago (2014-09-23 19:16:44 UTC) #13
pkx166h
rebase
4 years, 9 months ago (2014-09-25 15:26:40 UTC) #14
pkx166h
2 years, 3 months ago (2017-03-19 13:20:50 UTC) #15
author    James Lowe <pkx166h@gmail.com>   
    Sun, 21 Sep 2014 07:22:10 +0000 (08:22 +0100)
committer    James Lowe <pkx166h@gmail.com>   
    Thu, 2 Oct 2014 07:30:42 +0000 (08:30 +0100)
commit    [r3e53d84c47fffab7a5d5d23b23b2e3cb1c536eea]

Labels: -Patch-push Fixed_2_19_16
Status: Fixed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b