Issue 147860043: Changes.tely updated - 2.19.x up to September 2014 (Closed)
|
Created:
9 years, 7 months ago by pkx166h Modified:
7 years, 1 month ago CC:
lilypond-devel_gnu.org Visibility:
Public. |
DescriptionIssue 4122
Since June 2014.
Added Tracker issues
2813/3966, 3734/3825/3834, 4015, 4022,
4038, 4042, 4047, 4056, 4063, 4083,
and 4097.
Included @lilypond examples where appropriate
Patch Set 1 #
Total comments: 25
Patch Set 2 : Corrections as per Marc H, David K and Jean-Charles M. #Patch Set 3 : Updated commit message to tracker numbers removed from the initial patch. Minor TexInfo layout re-f… #Patch Set 4 : Make the code make. Sheesh... talk about sloppy! #
Total comments: 2
Patch Set 5 : With Heikki T's comments #Patch Set 6 : trying to fix doc compile issues #Patch Set 7 : rebase #MessagesTotal messages: 15
Hello, if those that have put in these recent features and enhancements that are listed in this checkin to the 'Changes' list can come up with some minimal examples to illustrate them I'd be very appreciative. I don't pretend to understand all the enhancements and if you think I have missed any or some are not appropriate and needn't be listed let me know.
Sign in to reply to this message.
https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:69: \once \override ChorName.text = #"foo" ChordName.text Maybe make this @lilypond? If you keep it "example", you'll also need to replace { with @{ and } with @} https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:72: @example More like @end example https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:75: with @code{DymanicTexts} or @code{LyricTexts}. I think you want all of those without the final s. And it's DynamicText rather than DymanicText. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:102: fonts other than the default Ementaler. Emmentaler. I'm not sure this makes sense without example or reference. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:106: grob can now be aligned on the @q{center} of its parent. Is this properly documented anywhere? If not, it's a bit hearsay without specifying at least that this goes via parent-alignment-X and parent-alignment-Y (if I remember correctly). https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:108: @item Improvements to the @code{\partial} command have been made to Bar checks are not a "parallel context", but since this is really more a bug fix than anything else, I'd just remove that item rather than haggle over its wording. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:113: aligned seperately rather than simply centered against the clef glyph. "separately", but again I think that's more a bug fix than anything else. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:120: @item Improvements made to smob functionality. Basic smob types Internals. Does not belong into Changes. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:150: @code{Rest_collision} grobs now ignore other grobs that do not use the I think that's again more of a bug fix than anything else. Basically, it reduces the number of warnings. I'd remove it rather than fix the spellings of the grob and interface names ;)
Sign in to reply to this message.
https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:127: the existing @code{\keepWithTag} and @code{removeWithTag} commands. For @code{\keepWithTag} and @code{\removeWithTag}
Sign in to reply to this message.
Just some minor nitpicks, as I cannot speak about the details of the recent changes. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:105: more flxeibility for grob positions. For example the @q{left} edge of a s/flxeibility/flexibility/ https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:118: @item The @code{NullVoice} context is now @q[below} @code{Score}. '{' instead of '[' in front of 'below'
Sign in to reply to this message.
Corrections as per Marc H, David K and Jean-Charles M.
Sign in to reply to this message.
Updated commit message to tracker numbers removed from the initial patch. Minor TexInfo layout re-formatting.
Sign in to reply to this message.
Thanks to those that checked. New patch uploaded https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:69: \once \override ChorName.text = #"foo" On 2014/09/21 09:59:37, dak wrote: > ChordName.text > > Maybe make this @lilypond? If you keep it "example", you'll also need to > replace { with @{ and } with @} Done. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:72: @example On 2014/09/21 09:59:38, dak wrote: > More like @end example Done. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:75: with @code{DymanicTexts} or @code{LyricTexts}. On 2014/09/21 09:59:37, dak wrote: > I think you want all of those without the final s. And it's DynamicText rather > than DymanicText. Done. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:102: fonts other than the default Ementaler. On 2014/09/21 09:59:38, dak wrote: > Emmentaler. I'm not sure this makes sense without example or reference. Typo done. I could think to do was link to openlily.org. Not sure if this is 'bad form' or not as it is not in our Doc as such but it is a nice enhancement. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:105: more flxeibility for grob positions. For example the @q{left} edge of a On 2014/09/21 10:20:40, marc wrote: > s/flxeibility/flexibility/ Done. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:106: grob can now be aligned on the @q{center} of its parent. On 2014/09/21 09:59:37, dak wrote: > Is this properly documented anywhere? If not, it's a bit hearsay without > specifying at least that this goes via parent-alignment-X and parent-alignment-Y > (if I remember correctly). Maybe Marc H can give a simple example I could add here or perhaps give a more 'technically correct' summary instead? https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:108: @item Improvements to the @code{\partial} command have been made to On 2014/09/21 09:59:37, dak wrote: > Bar checks are not a "parallel context", but since this is really more a bug fix > than anything else, I'd just remove that item rather than haggle over its > wording. Done. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:113: aligned seperately rather than simply centered against the clef glyph. On 2014/09/21 09:59:37, dak wrote: > "separately", but again I think that's more a bug fix than anything else. OK, removed (I really must install that spell check plug-in! to my editor). https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:118: @item The @code{NullVoice} context is now @q[below} @code{Score}. On 2014/09/21 10:20:40, marc wrote: > '{' instead of '[' in front of 'below' Done. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:120: @item Improvements made to smob functionality. Basic smob types On 2014/09/21 09:59:37, dak wrote: > Internals. Does not belong into Changes. Done. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:127: the existing @code{\keepWithTag} and @code{removeWithTag} commands. For On 2014/09/21 10:00:06, Jean-Charles wrote: > @code{\keepWithTag} and @code{\removeWithTag} Done. https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:150: @code{Rest_collision} grobs now ignore other grobs that do not use the On 2014/09/21 09:59:37, dak wrote: > I think that's again more of a bug fix than anything else. Basically, it > reduces the number of warnings. > > I'd remove it rather than fix the spellings of the grob and interface names ;) Done.
Sign in to reply to this message.
Make the code make. Sheesh... talk about sloppy!
Sign in to reply to this message.
https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/1/Documentation/changes.tely#ne... Documentation/changes.tely:106: grob can now be aligned on the @q{center} of its parent. On 2014/09/21 20:53:12, J_lowe wrote: > On 2014/09/21 09:59:37, dak wrote: > > Is this properly documented anywhere? If not, it's a bit hearsay without > > specifying at least that this goes via parent-alignment-X and > parent-alignment-Y > > (if I remember correctly). > > Maybe Marc H can give a simple example I could add here or perhaps give a more > 'technically correct' summary instead? IIRC it was Janek who did the alignment stuff – sorry, I cannot help here.
Sign in to reply to this message.
https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tel... Documentation/changes.tely:104: @end example Just a small note: While this example accurately describes the syntax for using the new context property, it doesn't explain what the property does: the property can be modified to alter the perceived volume of even sustained notes (albeit in a very low-level way). Here's a more complete (but longer, and still artificial) example to demonstrate the idea (if necessary). (There's also a higher-level music function to adjust the expression level attached to issue 4059, but this function can't be made to fit in the Changes document.) \score { \new Staff \with { midiExpression = #0.6 midiInstrument = #"clarinet" } << { a'1~ a'1 } { \set Staff.midiExpression = #0.7 s4\f\< \set Staff.midiExpression = #0.8 s4 \set Staff.midiExpression = #0.9 s4 \set Staff.midiExpression = #1.0 s4 \set Staff.midiExpression = #0.9 s4\> \set Staff.midiExpression = #0.8 s4 \set Staff.midiExpression = #0.7 s4 \set Staff.midiExpression = #0.6 s4\! } >> \midi { } }
Sign in to reply to this message.
With Heikki T's comments
Sign in to reply to this message.
trying to fix doc compile issues
Sign in to reply to this message.
https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/147860043/diff/50001/Documentation/changes.tel... Documentation/changes.tely:104: @end example On 2014/09/22 18:19:52, ht wrote: > Just a small note: While this example accurately describes the syntax for using > the new context property, it doesn't explain what the property does: the > property can be modified to alter the perceived volume of even sustained notes > (albeit in a very low-level way). Here's a more complete (but longer, and still > artificial) example to demonstrate the idea (if necessary). (There's also a > higher-level music function to adjust the expression level attached to issue > 4059, but this function can't be made to fit in the Changes document.) > > \score { > \new Staff \with { > midiExpression = #0.6 > midiInstrument = #"clarinet" > } > << > { a'1~ a'1 } > { > \set Staff.midiExpression = #0.7 s4\f\< > \set Staff.midiExpression = #0.8 s4 > \set Staff.midiExpression = #0.9 s4 > \set Staff.midiExpression = #1.0 s4 > > \set Staff.midiExpression = #0.9 s4\> > \set Staff.midiExpression = #0.8 s4 > \set Staff.midiExpression = #0.7 s4 > \set Staff.midiExpression = #0.6 s4\! > } > >> > \midi { } > } > Thanks, updated.
Sign in to reply to this message.
rebase
Sign in to reply to this message.
author James Lowe <pkx166h@gmail.com> Sun, 21 Sep 2014 07:22:10 +0000 (08:22 +0100) committer James Lowe <pkx166h@gmail.com> Thu, 2 Oct 2014 07:30:42 +0000 (08:30 +0100) commit [r3e53d84c47fffab7a5d5d23b23b2e3cb1c536eea] Labels: -Patch-push Fixed_2_19_16 Status: Fixed
Sign in to reply to this message.
|
