Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 147730043: code review 147730043: image/gif: fix GIF encoding of sub-images. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by nigeltao
Modified:
7 years, 8 months ago
Reviewers:
r
CC:
r, dbathgate, golang-codereviews
Visibility:
Public.

Description

image/gif: fix GIF encoding of sub-images. benchmark old ns/op new ns/op delta BenchmarkEncode 8641055 8646829 +0.07% Fixes issue 7792.

Patch Set 1 #

Patch Set 2 : diff -r b18ebcb9f2367d52af8c3515dee63888ca96db70 https://code.google.com/p/go/ #

Patch Set 3 : diff -r b18ebcb9f2367d52af8c3515dee63888ca96db70 https://code.google.com/p/go/ #

Total comments: 1

Patch Set 4 : diff -r b18ebcb9f2367d52af8c3515dee63888ca96db70 https://code.google.com/p/go/ #

Patch Set 5 : diff -r a92a99ba40fb030955680fc19b1a489548049121 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -4 lines) Patch
M src/image/gif/writer.go View 1 2 3 1 chunk +14 lines, -4 lines 0 comments Download
M src/image/gif/writer_test.go View 1 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5
nigeltao
Hello r@golang.org (cc: dbathgate@google.com, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
7 years, 8 months ago (2014-09-17 07:40:48 UTC) #1
r
https://codereview.appspot.com/147730043/diff/40001/src/image/gif/writer.go File src/image/gif/writer.go (right): https://codereview.appspot.com/147730043/diff/40001/src/image/gif/writer.go#newcode236 src/image/gif/writer.go:236: for i, dx, y := 0, b.Dx(), b.Min.Y; y ...
7 years, 8 months ago (2014-09-17 14:41:54 UTC) #2
nigeltao
On 2014/09/17 14:41:54, r wrote: > https://codereview.appspot.com/147730043/diff/40001/src/image/gif/writer.go > File src/image/gif/writer.go (right): > > https://codereview.appspot.com/147730043/diff/40001/src/image/gif/writer.go#newcode236 > ...
7 years, 8 months ago (2014-09-18 00:19:37 UTC) #3
r
LGTM for big images it probably matters more
7 years, 8 months ago (2014-09-18 02:01:48 UTC) #4
nigeltao
7 years, 8 months ago (2014-09-18 02:43:14 UTC) #5
*** Submitted as https://code.google.com/p/go/source/detail?r=541f4c85dfed ***

image/gif: fix GIF encoding of sub-images.

benchmark                    old ns/op     new ns/op     delta
BenchmarkEncode              8641055       8646829       +0.07%

Fixes issue 7792.

LGTM=r
R=r
CC=dbathgate, golang-codereviews
https://codereview.appspot.com/147730043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b