Issue 14772044: Fix string encoding problem in guiserver.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14772044: Fix string encoding problem in guiserver.

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by frankban

Modified:
10 years, 6 months ago

Reviewers:
mp+191630, gary.poster

Visibility:
Public.

Description

Fix string encoding problem in guiserver. The Juju API connection was dropped as result of an error while logging responses containing non-ascii characters. https://code.launchpad.net/~frankban/charms/precise/juju-gui/encoding-problem/+merge/191630 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix string encoding problem in guiserver. #

Patch Set 3 : Fix string encoding problem in guiserver. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -14 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	revision	View		1 chunk	+1 line, -1 line	0 comments	Download
M	server/guiserver/auth.py	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	server/guiserver/bundles/utils.py	View	1 2	2 chunks	+5 lines, -2 lines	0 comments	Download
M	server/guiserver/handlers.py	View		3 chunks	+7 lines, -4 lines	0 comments	Download
M	server/guiserver/tests/test_handlers.py	View		2 chunks	+12 lines, -2 lines	0 comments	Download
M	server/guiserver/tests/test_utils.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	server/guiserver/utils.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gary.poster

LGTM and QA OK, thank you! IRC notes below <gary_poster> frankban, shouldn't we have encoding ...

10 years, 6 months ago (2013-10-17 13:39:40 UTC) #3

frankban

On 2013/10/17 13:39:40, gary.poster wrote: > LGTM and QA OK, thank you! IRC notes below ...

10 years, 6 months ago (2013-10-17 14:13:38 UTC) #4

frankban

10 years, 6 months ago (2013-10-17 14:18:54 UTC) #5

*** Submitted:

Fix string encoding problem in guiserver.

The Juju API connection was dropped as
result of an error while logging responses
containing non-ascii characters.

R=gary.poster
CC=
https://codereview.appspot.com/14772044

Expand All Messages | Collapse All Messages