Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8788)

Issue 14771044: Fix initial centering of canvas in real env.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by matthew.scott
Modified:
10 years, 6 months ago
Reviewers:
mp+191681
Visibility:
Public.

Description

Fix initial centering of canvas in real env. In a real environment with positioned services, this centers the services within the viewport, an artifact that was lost in a recent refactor. Also tests that the panToPoint event was fired when a positioned service is added (future designs will complicate this, as the inspector will have an arrow pointing to a service, if it's open; this will be prevented in app/views/topology/service.js:panToCenter() once that's implemented). Other tests in place already test finding and setting the centroid. https://code.launchpad.net/~makyo/juju-gui/center/+merge/191681 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix initial centering of canvas in real env. #

Patch Set 3 : Fix initial centering of canvas in real env. #

Patch Set 4 : Fix initial centering of canvas in real env. #

Patch Set 5 : Fix initial centering of canvas in real env. #

Patch Set 6 : Fix initial centering of canvas in real env. #

Patch Set 7 : Fix initial centering of canvas in real env. #

Patch Set 8 : Fix initial centering of canvas in real env. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -28 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/views/topology/service.js View 3 chunks +20 lines, -12 lines 0 comments Download
M test/test_environment_view.js View 3 chunks +8 lines, -16 lines 0 comments Download

Messages

Total messages: 2
matthew.scott
Please take a look.
10 years, 6 months ago (2013-10-17 17:08:19 UTC) #1
matthew.scott
10 years, 6 months ago (2013-10-17 20:30:41 UTC) #2
*** Submitted:

Fix initial centering of canvas in real env.

In a real environment with positioned services, this centers the services within
the viewport, an artifact that was lost in a recent refactor.  Also tests that
the panToPoint event was fired when a positioned service is added (future
designs will complicate this, as the inspector will have an arrow pointing to a
service, if it's open; this will be prevented in
app/views/topology/service.js:panToCenter() once that's implemented).  Other
tests in place already test finding and setting the centroid.

R=
CC=
https://codereview.appspot.com/14771044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b