code review 14762044: database/sql: fix some test fmt verbs

database/sql: fix some test fmt verbs

Found by vet.

[bradfitz, 2013-10-16 22:06:26]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://go.googlecode.com/hg/

[r, 2013-10-16 23:25:21]

LGTM

[bradfitz, 2013-10-16 23:30:42]

*** Submitted as https://code.google.com/p/go/source/detail?r=7e04f28e139a ***

database/sql: fix some test fmt verbs

Found by vet.

R=golang-dev, r
CC=golang-dev
https://codereview.appspot.com/14762044

[adg1, 2013-10-17 00:28:48]

LGTM
On 17 Oct 2013 07:06, <bradfitz@golang.org> wrote:

> Reviewers: golang-dev1,
>
> Message:
> Hello golang-dev@googlegroups.com,
>
> I'd like you to review this change to
> https://go.googlecode.com/hg/
>
>
> Description:
> database/sql: fix some test fmt verbs
>
> Found by vet.
>
> Please review this at
https://codereview.appspot.**com/14762044/<https://codereview.appspot.com/147...
>
> Affected files (+4, -4 lines):
>   M src/pkg/database/sql/convert_**test.go
>   M src/pkg/database/sql/driver/**types_test.go
>
>
> Index: src/pkg/database/sql/convert_**test.go
> ==============================**==============================**=======
> --- a/src/pkg/database/sql/**convert_test.go
> +++ b/src/pkg/database/sql/**convert_test.go
> @@ -267,14 +267,14 @@
>                         goterr = err.Error()
>                 }
>                 if goterr != tt.err {
> -                       t.Errorf("test %d: %s(%T(%v)) error = %q; want
> error = %q",
> +                       t.Errorf("test %d: %T(%T(%v)) error = %q; want
> error = %q",
>                                 i, tt.c, tt.in, tt.in, goterr, tt.err)
>                 }
>                 if tt.err != "" {
>                         continue
>                 }
>                 if !reflect.DeepEqual(out, tt.out) {
> -                       t.Errorf("test %d: %s(%T(%v)) = %v (%T); want %v
> (%T)",
> +                       t.Errorf("test %d: %T(%T(%v)) = %v (%T); want %v
> (%T)",
>                                 i, tt.c, tt.in, tt.in, out, out, tt.out,
> tt.out)
>                 }
>         }
> Index: src/pkg/database/sql/driver/**types_test.go
> ==============================**==============================**=======
> --- a/src/pkg/database/sql/driver/**types_test.go
> +++ b/src/pkg/database/sql/driver/**types_test.go
> @@ -51,14 +51,14 @@
>                         goterr = err.Error()
>                 }
>                 if goterr != tt.err {
> -                       t.Errorf("test %d: %s(%T(%v)) error = %q; want
> error = %q",
> +                       t.Errorf("test %d: %T(%T(%v)) error = %q; want
> error = %q",
>                                 i, tt.c, tt.in, tt.in, goterr, tt.err)
>                 }
>                 if tt.err != "" {
>                         continue
>                 }
>                 if !reflect.DeepEqual(out, tt.out) {
> -                       t.Errorf("test %d: %s(%T(%v)) = %v (%T); want %v
> (%T)",
> +                       t.Errorf("test %d: %T(%T(%v)) = %v (%T); want %v
> (%T)",
>                                 i, tt.c, tt.in, tt.in, out, out, tt.out,
> tt.out)
>                 }
>         }
>
>
> --
>
> ---You received this message because you are subscribed to the Google
> Groups "golang-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to
golang-dev+unsubscribe@**googlegroups.com<golang-dev%2Bunsubscribe@googlegrou...
> .
> For more options, visit
https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/o...
> .
>