Issue 147380043: code review 147380043: compress/*: note that NewReader may introduce buffering

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 147380043: code review 147380043: compress/*: note that NewReader may introduce buffering (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by rsc

Modified:
10 years, 5 months ago

Reviewers:
r

CC:
golang-codereviews, r, iant

Visibility:
Public.

Description

compress/*: note that NewReader may introduce buffering Fixes issue 8309.

Patch Set 1 #

Patch Set 2 : diff -r cd24f5ff3db869a41efbf3a83e9e3f55b61460b8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r cd24f5ff3db869a41efbf3a83e9e3f55b61460b8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r d539076652f878dd581537c4d30edd2b811877dc https://code.google.com/p/go/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -4 lines)			Patch
M	src/compress/bzip2/bzip2.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/compress/flate/inflate.go	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	src/compress/gzip/gunzip.go	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/compress/lzw/reader.go	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

rsc

Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/

10 years, 5 months ago (2014-09-30 15:49:59 UTC) #1

LGTM in the documentation for fmt.Scan, i point out that it may be valuable to ...

10 years, 5 months ago (2014-09-30 16:09:56 UTC) #2

rsc

i can't come up with a wording i'm happy with mentioning bufio.Reader. will leave as ...

10 years, 5 months ago (2014-09-30 16:31:00 UTC) #3

rsc

10 years, 5 months ago (2014-09-30 16:31:22 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=6e19c3e6b95c ***

compress/*: note that NewReader may introduce buffering

Fixes issue 8309.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://codereview.appspot.com/147380043

Expand All Messages | Collapse All Messages