Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2)

Issue 147360043: Remove symlink before re-creating it.

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by frankban
Modified:
10 years, 5 months ago
Reviewers:
mp+236376, rharding
Visibility:
Public.

Description

Remove symlink before re-creating it. Remove the release symlink to the target directory served by the GUI server vefore (re)creating it. This should solve spurious errors while trying to force the removal of a pre-existing target link. Also remove the no longer required revision file (and added it to bzrignore). The file generated a conflict in the last prodstack deployment. https://code.launchpad.net/~frankban/charms/trusty/juju-gui/rm-symlink/+merge/236376 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Remove symlink before re-creating it. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M .bzrignore View 1 chunk +4 lines, -3 lines 0 comments Download
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M hooks/utils.py View 1 chunk +2 lines, -1 line 0 comments Download
D revision View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6
frankban
Please take a look.
10 years, 5 months ago (2014-09-29 15:44:23 UTC) #1
rharding
code looks good, starting live test run qa.
10 years, 5 months ago (2014-09-29 15:59:29 UTC) #2
rharding
On 2014/09/29 15:59:29, rharding wrote: > code looks good, starting live test run qa. LGTM
10 years, 5 months ago (2014-09-29 17:25:13 UTC) #3
rharding
On 2014/09/29 15:59:29, rharding wrote: > code looks good, starting live test run qa. LGTM
10 years, 5 months ago (2014-09-29 17:25:24 UTC) #4
frankban
*** Submitted: Remove symlink before re-creating it. Remove the release symlink to the target directory ...
10 years, 5 months ago (2014-09-30 08:10:59 UTC) #5
frankban
10 years, 5 months ago (2014-09-30 08:13:29 UTC) #6
Hi Rick,
thanks for the review!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b