Issue 14725044: Subordinate service should not export num_units

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14725044: Subordinate service should not export num_units

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by gary.poster

Modified:
10 years, 6 months ago

Reviewers:
frankban, mp+191321

Visibility:
Public.

Description

Subordinate service should not export num_units Fix for deployer output. https://code.launchpad.net/~gary/juju-gui/bug1240230/+merge/191321 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Subordinate service should not export num_units #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -7 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/models/models.js	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/test_model.js	View	4 chunks	+13 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

*** Submitted: Subordinate service should not export num_units Fix for deployer output. R=frankban CC= https://codereview.appspot.com/14725044

10 years, 6 months ago (2013-10-16 11:56:19 UTC) #3

gary.poster

10 years, 6 months ago (2013-10-16 11:57:01 UTC) #4

On 2013/10/16 11:56:19, gary.poster wrote:
> *** Submitted:
> 
> Subordinate service should not export num_units
> 
> Fix for deployer output.
> 
> R=frankban
> CC=
> https://codereview.appspot.com/14725044

Thank you Francesco, and sorry for forgetting to describe QA steps.  Thanks for
figuring them out. :-)

Expand All Messages | Collapse All Messages