Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(155)

Issue 14717043: code review 14717043: cmd/cgo: simpler fix for issue 6506. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by minux1
Modified:
12 years ago
Reviewers:
dave, rsc, iant
CC:
rsc, iant, dave_cheney.net, golang-dev
Visibility:
Public.

Description

cmd/cgo: simpler fix for issue 6506. Replaces CL 14682044. Fixes issue 6506.

Patch Set 1 #

Patch Set 2 : diff -r 9d0d95344a6c https://code.google.com/p/go #

Patch Set 3 : diff -r 9d0d95344a6c https://code.google.com/p/go #

Patch Set 4 : diff -r 9d0d95344a6c https://code.google.com/p/go #

Total comments: 1

Patch Set 5 : diff -r 9d0d95344a6c https://code.google.com/p/go #

Patch Set 6 : diff -r 9d0d95344a6c https://code.google.com/p/go #

Patch Set 7 : diff -r 21fb692d02e7 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -46 lines) Patch
M src/cmd/cgo/gcc.go View 1 2 3 4 7 chunks +9 lines, -46 lines 0 comments Download

Messages

Total messages: 9
iant
LGTM but wait for rsc. https://codereview.appspot.com/14717043/diff/7001/src/cmd/cgo/gcc.go File src/cmd/cgo/gcc.go (right): https://codereview.appspot.com/14717043/diff/7001/src/cmd/cgo/gcc.go#newcode763 src/cmd/cgo/gcc.go:763: // by disable the ...
12 years ago (2013-10-15 21:40:42 UTC) #1
minux1
Hello rsc@golang.org, iant@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
12 years ago (2013-10-15 21:46:40 UTC) #2
dave_cheney.net
On 2013/10/15 21:46:40, minux wrote: > Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc: mailto:golang-dev@googlegroups.com), > > I'd like ...
12 years ago (2013-10-15 23:50:34 UTC) #3
dave_cheney.net
On 2013/10/15 23:50:34, dfc wrote: > On 2013/10/15 21:46:40, minux wrote: > > Hello mailto:rsc@golang.org, ...
12 years ago (2013-10-15 23:54:24 UTC) #4
minux1
Thank you for testing. On Tue, Oct 15, 2013 at 7:50 PM, <dave@cheney.net> wrote: > ...
12 years ago (2013-10-16 00:11:12 UTC) #5
dave_cheney.net
I thought they might be unrelated. For Darwin/Xcore5 LGTM. On Wed, Oct 16, 2013 at ...
12 years ago (2013-10-16 00:13:06 UTC) #6
rsc
LGTM put fixes issue 6506 into the CL description so the checkin will be linked ...
12 years ago (2013-10-16 01:14:13 UTC) #7
minux1
Hi Russ, could we revert CL 13413047, 13345048 and 13878043 involving our malloc wrapper given ...
12 years ago (2013-10-16 01:35:16 UTC) #8
minux1
12 years ago (2013-10-16 01:35:57 UTC) #9
*** Submitted as https://code.google.com/p/go/source/detail?r=050f1f96c25c ***

cmd/cgo: simpler fix for issue 6506.
Replaces CL 14682044.
Fixes issue 6506.

R=rsc, iant, dave
CC=golang-dev
https://codereview.appspot.com/14717043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b