code review 14717043: cmd/cgo: simpler fix for issue 6506.

cmd/cgo: simpler fix for issue 6506.
Replaces CL 14682044.
Fixes issue 6506.

[iant, 2013-10-15 21:40:42]

LGTM but wait for rsc.

https://codereview.appspot.com/14717043/diff/7001/src/cmd/cgo/gcc.go
File src/cmd/cgo/gcc.go (right):

https://codereview.appspot.com/14717043/diff/7001/src/cmd/cgo/gcc.go#newcode763
src/cmd/cgo/gcc.go:763: // by disable the builtin functions (this is safe as it
s/disable/disabling/

[minux1, 2013-10-15 21:46:40]

Hello rsc@golang.org, iant@golang.org (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2013-10-15 23:50:34]

On 2013/10/15 21:46:40, minux wrote:
> Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc:
mailto:golang-dev@googlegroups.com),
> 
> I'd like you to review this change to
> https://code.google.com/p/go

Darwin + Xcode5 is fine. One failure so far on linux 

# _/home/dfc/go/misc/cgo/testcdefs
./cdefstest.h:13 ./cdefstest.c:6 array size must be a positive constant
./cdefstest.h:15 ./cdefstest.c:6 array size must be a positive constant
./cdefstest.h:17 ./cdefstest.c:6 array size must be a positive constant

lucky(~/go/src) % echo $CC
/home/dfc/bin/clang+llvm-3.2-x86_64-linux-ubuntu-12.04/bin/clang
lucky(~/go/src) % $CC -v
clang version 3.2 (tags/RELEASE_32/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix

[dave_cheney.net, 2013-10-15 23:54:24]

On 2013/10/15 23:50:34, dfc wrote:
> On 2013/10/15 21:46:40, minux wrote:
> > Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc:
> mailto:golang-dev@googlegroups.com),
> > 
> > I'd like you to review this change to
> > https://code.google.com/p/go
> 
> Darwin + Xcode5 is fine. One failure so far on linux 
> 
> # _/home/dfc/go/misc/cgo/testcdefs
> ./cdefstest.h:13 ./cdefstest.c:6 array size must be a positive constant
> ./cdefstest.h:15 ./cdefstest.c:6 array size must be a positive constant
> ./cdefstest.h:17 ./cdefstest.c:6 array size must be a positive constant
> 
> lucky(~/go/src) % echo $CC
> /home/dfc/bin/clang+llvm-3.2-x86_64-linux-ubuntu-12.04/bin/clang
> lucky(~/go/src) % $CC -v
> clang version 3.2 (tags/RELEASE_32/final)
> Target: x86_64-unknown-linux-gnu
> Thread model: posix

clang-3.3, linux/amd64 and linux/386

# _/home/dfc/go/misc/cgo/testcdefs
./cdefstest.h:12 ./cdefstest.c:6 array size must be a positive constant
./cdefstest.h:14 ./cdefstest.c:6 array size must be a positive constant
./cdefstest.h:16 ./cdefstest.c:6 array size must be a positive constant
220887(~/go/src) % clang -v
clang version 3.3 (trunk 168417) (llvm/trunk 168416)
Target: i386-pc-linux-gnu
Thread model: posix

# _/home/dfc/go/misc/cgo/testcdefs
./cdefstest.h:13 ./cdefstest.c:6 array size must be a positive constant
./cdefstest.h:15 ./cdefstest.c:6 array size must be a positive constant
./cdefstest.h:17 ./cdefstest.c:6 array size must be a positive constant
lucky(~/go/src) % $CC -v
clang version 3.3 (tags/RELEASE_33/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix

[minux1, 2013-10-16 00:11:12]

Thank you for testing.

On Tue, Oct 15, 2013 at 7:50 PM, <dave@cheney.net> wrote:

> On 2013/10/15 21:46:40, minux wrote:
>
>> Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc:
>>
> mailto:golang-dev@**googlegroups.com <golang-dev@googlegroups.com>),
>
>
>  I'd like you to review this change to
>> https://code.google.com/p/go
>>
>
> Darwin + Xcode5 is fine. One failure so far on linux
>
> # _/home/dfc/go/misc/cgo/**testcdefs
> ./cdefstest.h:13 ./cdefstest.c:6 array size must be a positive constant
> ./cdefstest.h:15 ./cdefstest.c:6 array size must be a positive constant
> ./cdefstest.h:17 ./cdefstest.c:6 array size must be a positive constant
>
this failure also happens w/o this patch, and I'm going to look at it.

>
> lucky(~/go/src) % echo $CC
> /home/dfc/bin/clang+llvm-3.2-**x86_64-linux-ubuntu-12.04/bin/**clang
> lucky(~/go/src) % $CC -v
> clang version 3.2 (tags/RELEASE_32/final)
> Target: x86_64-unknown-linux-gnu
> Thread model: posix

[dave_cheney.net, 2013-10-16 00:13:06]

I thought they might be unrelated.

For Darwin/Xcore5 LGTM.

On Wed, Oct 16, 2013 at 11:10 AM, minux <minux.ma@gmail.com> wrote:
> Thank you for testing.
>
> On Tue, Oct 15, 2013 at 7:50 PM, <dave@cheney.net> wrote:
>>
>> On 2013/10/15 21:46:40, minux wrote:
>>>
>>> Hello mailto:rsc@golang.org, mailto:iant@golang.org (cc:
>>
>> mailto:golang-dev@googlegroups.com),
>>
>>
>>> I'd like you to review this change to
>>> https://code.google.com/p/go
>>
>>
>> Darwin + Xcode5 is fine. One failure so far on linux
>>
>> # _/home/dfc/go/misc/cgo/testcdefs
>> ./cdefstest.h:13 ./cdefstest.c:6 array size must be a positive constant
>> ./cdefstest.h:15 ./cdefstest.c:6 array size must be a positive constant
>> ./cdefstest.h:17 ./cdefstest.c:6 array size must be a positive constant
>
> this failure also happens w/o this patch, and I'm going to look at it.
>>
>>
>> lucky(~/go/src) % echo $CC
>> /home/dfc/bin/clang+llvm-3.2-x86_64-linux-ubuntu-12.04/bin/clang
>> lucky(~/go/src) % $CC -v
>> clang version 3.2 (tags/RELEASE_32/final)
>> Target: x86_64-unknown-linux-gnu
>> Thread model: posix

[rsc, 2013-10-16 01:14:13]

LGTM
put fixes issue 6506 into the CL description so the checkin will be linked on
the bug

[minux1, 2013-10-16 01:35:16]

Hi Russ, could we revert CL 13413047, 13345048 and 13878043
involving our malloc wrapper given that we fixed the root cause?

Not super important for Go 1.2, but I suggest we get rid of them
eventually.

[minux1, 2013-10-16 01:35:57]

*** Submitted as https://code.google.com/p/go/source/detail?r=050f1f96c25c ***

cmd/cgo: simpler fix for issue 6506.
Replaces CL 14682044.
Fixes issue 6506.

R=rsc, iant, dave
CC=golang-dev
https://codereview.appspot.com/14717043