Issue 14702045: Bundle tabview now reacts to the url hash

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14702045: Bundle tabview now reacts to the url hash

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by jeff.pihach

Modified:
10 years, 6 months ago

Reviewers:
mp+191680, matthew.scott

Visibility:
Public.

Description

Bundle tabview now reacts to the url hash https://code.launchpad.net/~hatch/juju-gui/bundle-tabs-1240973/+merge/191680 (do not edit description out of merge proposal)

Patch Set 2 : Bundle tabview now reacts to the url hash #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+51 lines, -20 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/bundle.js	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	app/subapps/browser/views/charm.js	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	app/subapps/browser/views/entity-base.js	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	test/test_bundle_details_view.js	View	2 chunks	+31 lines, -11 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

jeff.pihach

Review notes https://codereview.appspot.com/14702045/diff/1/app/subapps/browser/views/charm.js File app/subapps/browser/views/charm.js (left): https://codereview.appspot.com/14702045/diff/1/app/subapps/browser/views/charm.js#oldcode364 app/subapps/browser/views/charm.js:364: if (this.get('activeTab')) { Moved to entity-base.js

10 years, 6 months ago (2013-10-17 17:03:21 UTC) #2

jeff.pihach

10 years, 6 months ago (2013-10-17 17:26:26 UTC) #5

*** Submitted:

Bundle tabview now reacts to the url hash

R=matthew.scott
CC=
https://codereview.appspot.com/14702045

Expand All Messages | Collapse All Messages