Issue 14702043: code review 14702043: cmd/cgo: fix Xcode 5 incompatibility for #defined expre...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14702043: code review 14702043: cmd/cgo: fix Xcode 5 incompatibility for #defined expre... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by rsc

Modified:
11 years, 6 months ago

Reviewers:
minux1, iant

CC:
golang-dev, iant, minux1

Visibility:
Public.

Description

cmd/cgo: fix Xcode 5 incompatibility for #defined expressions Ensure that clang always exits with a non-zero status by giving it something that it always warns about (the statement "1;"). Fixes issue 6128.

Patch Set 1 #

Patch Set 2 : diff -r 9d37839d46e8 https://code.google.com/p/go/ #

Patch Set 3 : diff -r 9d37839d46e8 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 9d37839d46e8 https://code.google.com/p/go/ #

Total comments: 2

Patch Set 5 : diff -r 9d37839d46e8 https://code.google.com/p/go/ #

Patch Set 6 : diff -r 21d967e09620 https://code.google.com/p/go/ #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	A	misc/cgo/test/issue6128.go	View	1	1 chunk	+20 lines, -0 lines	0 comments	Download
	M	src/cmd/cgo/gcc.go	View	1 2 3 4	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

rsc

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/

11 years, 6 months ago (2013-10-15 16:52:06 UTC) #1

iant

https://codereview.appspot.com/14702043/diff/8001/src/cmd/cgo/gcc.go File src/cmd/cgo/gcc.go (right): https://codereview.appspot.com/14702043/diff/8001/src/cmd/cgo/gcc.go#newcode317 src/cmd/cgo/gcc.go:317: fmt.Fprintf(&b, "1;\n") If this works, then why not instead ...

11 years, 6 months ago (2013-10-15 17:19:56 UTC) #2

rsc

11 years, 6 months ago (2013-10-15 17:42:39 UTC) #3

rsc

11 years, 6 months ago (2013-10-15 18:34:49 UTC) #6

*** Submitted as https://code.google.com/p/go/source/detail?r=db3b617c8f86 ***

cmd/cgo: fix Xcode 5 incompatibility for #defined expressions

Ensure that clang always exits with a non-zero status by
giving it something that it always warns about (the statement "1;").

Fixes issue 6128.

R=golang-dev, iant, minux.ma
CC=golang-dev
https://codereview.appspot.com/14702043

Expand All Messages | Collapse All Messages