DescriptionRedo Service Placement
This changes a number of aspects of how service placement is handled. There
may still be some edge cases and QA will need to be extensive as this
has moved through phases where various parts worked and didn't. I believe
this version to be good however.
Position annotations remain on service models now rather than being deleted
when applied. We favor this to having vars such as hasBeenPositioned,
positionedFromGhost and service model x/y (which mixed into BoundingBoxes).
These various complications are mostly gone and the handling of updating
position annotations falls to a single method on the topology. (Though to be
fair that is still called from more than one place).
Further simplification might be possible by unifying the node creation and
node update paths wrt annotations. This didn't however fit in the time
provided.
This also includes a basic fix for always pulling positions from the client
during an export.
https://code.launchpad.net/~bcsaller/juju-gui/exportXY/+merge/191119
(do not edit description out of merge proposal)
Patch Set 1 #
Total comments: 30
Patch Set 2 : Redo Service Placement #
Total comments: 13
Patch Set 3 : Redo Service Placement #Patch Set 4 : Redo Service Placement #
MessagesTotal messages: 11
|