code review 14669046: go.crypto/ssh: move channelForwardMsg declaration.

go.crypto/ssh: move channelForwardMsg declaration.

[hanwen-google, 2013-10-15 14:52:27]

Hello golang-dev@googlegroups.com (cc: dave@cheney.net),

I'd like you to review this change to
https://code.google.com/p/go.crypto

[dave_cheney.net, 2013-10-16 03:05:25]

Please fix the description, I suggest removing the last two words. Apart from
the LGTM. 

> On 16 Oct 2013, at 1:52, hanwen@google.com wrote:
> 
> Reviewers: golang-dev1,
> 
> Message:
> Hello golang-dev@googlegroups.com (cc: dave@cheney.net),
> 
> I'd like you to review this change to
> https://code.google.com/p/go.crypto
> 
> 
> Description:
> go.crypto/ssh: move channelForwardMsg declaration to use.
> 
> Please review this at https://codereview.appspot.com/14669046/
> 
> Affected files (+8, -8 lines):
>  M ssh/tcpip.go
> 
> 
> Index: ssh/tcpip.go
> ===================================================================
> --- a/ssh/tcpip.go
> +++ b/ssh/tcpip.go
> @@ -27,14 +27,6 @@
>    return c.ListenTCP(laddr)
> }
> 
> -// RFC 4254 7.1
> -type channelForwardMsg struct {
> -    Message   string
> -    WantReply bool
> -    raddr     string
> -    rport     uint32
> -}
> -
> // Automatic port allocation is broken with OpenSSH before 6.0. See
> // also https://bugzilla.mindrot.org/show_bug.cgi?id=2017.  In
> // particular, OpenSSH 5.9 sends a channelOpenMsg with port number 0,
> @@ -83,6 +75,14 @@
>    return nil, fmt.Errorf("ssh: listen on random port failed after %d tries:
%v", tries, err)
> }
> 
> +// RFC 4254 7.1
> +type channelForwardMsg struct {
> +    Message   string
> +    WantReply bool
> +    raddr     string
> +    rport     uint32
> +}
> +
> // ListenTCP requests the remote peer open a listening socket
> // on laddr. Incoming connections will be available by calling
> // Accept on the returned net.Listener.
> 
> 

[hanwen-google, 2013-10-16 03:18:19]

done.

[dave_cheney.net, 2013-10-16 03:19:17]

Sorry, you have to mail it again.

On Wed, Oct 16, 2013 at 2:18 PM,  <hanwen@google.com> wrote:
> done.
>
> https://codereview.appspot.com/14669046/

[hanwen-google, 2013-10-16 03:21:44]

Hello golang-dev@googlegroups.com (cc: dave@cheney.net,
golang-dev@googlegroups.com),

Please take another look.

[dave_cheney.net, 2013-10-16 03:23:35]

On 2013/10/16 03:21:44, hanwen-google wrote:
> Hello mailto:golang-dev@googlegroups.com (cc: mailto:dave@cheney.net,
> mailto:golang-dev@googlegroups.com),
> 
> Please take another look.

LGTM. Submitting

[dave_cheney.net, 2013-10-16 03:24:46]

*** Submitted as
https://code.google.com/p/go/source/detail?r=c4541c017178&repo=crypto ***

go.crypto/ssh: move channelForwardMsg declaration.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/14669046

Committer: Dave Cheney <dave@cheney.net>