Issue 14668044: Set Close = true for http Requests.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14668044: Set Close = true for http Requests. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by wallyworld

Modified:
10 years, 6 months ago

Reviewers:
mp+191557, thumper

Visibility:
Public.

Description

Set Close = true for http Requests. This is needed to avoid this bug in Go's http lib: https://code.google.com/p/go/issues/detail?id=4677 As soon as the goose branch lands, I'll update dependencies.tsv and then land this branch. https://code.launchpad.net/~wallyworld/juju-core/fix-request-eof/+merge/191557 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Set Close = true for http Requests. #

Total comments: 1

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -15 lines)			Patch
[revision details]	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
cmd/cmd.go	View	1	1 chunk	+7 lines, -0 lines	1 comment	Download
cmd/cmd_test.go	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
dependencies.tsv	View		1 chunk	+2 lines, -2 lines	0 comments	Download
environs/httpstorage/backend_test.go	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
environs/httpstorage/storage.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
environs/simplestreams/datasource.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
environs/simplestreams/simplestreams.go	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download
utils/http.go	View	1	1 chunk	+25 lines, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

thumper

10 years, 6 months ago (2013-10-17 23:10:58 UTC) #3

LGTM

https://codereview.appspot.com/14668044/diff/4001/cmd/cmd.go
File cmd/cmd.go (right):

https://codereview.appspot.com/14668044/diff/4001/cmd/cmd.go#newcode22
cmd/cmd.go:22: 
we are going to be replacing the default transport multiple times...

Expand All Messages | Collapse All Messages