Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1370)

Issue 14665043: environs/cloudinit: simplify testing

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by rog
Modified:
10 years, 6 months ago
Reviewers:
mue, mp+190939
Visibility:
Public.

Description

environs/cloudinit: simplify testing Allow inexact matching of cloudinit output so that tests can more closely fit what they're actually trying to test. https://code.launchpad.net/~rogpeppe/juju-core/449-cloudinit-inexact/+merge/190939 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : environs/cloudinit: simplify testing #

Patch Set 3 : environs/cloudinit: simplify testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -192 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M environs/cloudinit/cloudinit_test.go View 9 chunks +89 lines, -192 lines 0 comments Download

Messages

Total messages: 3
rog
Please take a look.
10 years, 6 months ago (2013-10-14 12:43:39 UTC) #1
rog
Please take a look.
10 years, 6 months ago (2013-10-14 12:49:58 UTC) #2
mue
10 years, 6 months ago (2013-10-14 13:06:13 UTC) #3
LGTM, a real nice one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b