Issue 146610043: code review 146610043: tag go1.3.3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 146610043: code review 146610043: tag go1.3.3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by adg

Modified:
10 years, 5 months ago

Reviewers:
gobot, crawshaw

CC:
golang-codereviews, crawshaw

Visibility:
Public.

Description

tag go1.3.3

Patch Set 1 #

Patch Set 2 : diff -r 1c674c3eefc7c3c2c73378bd2482a08b933839ee https://code.google.com/p/go #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	.hgtags	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

adg

Hello golang-codereviews@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go

10 years, 5 months ago (2014-10-01 03:03:38 UTC) #1

adg

*** Submitted as https://code.google.com/p/go/source/detail?r=304279587445 *** tag go1.3.3 LGTM=crawshaw R=golang-codereviews, crawshaw CC=golang-codereviews https://codereview.appspot.com/146610043

10 years, 5 months ago (2014-10-01 03:38:11 UTC) #3

gobot

10 years, 5 months ago (2014-10-01 17:23:05 UTC) #4

Message was sent while issue was closed.

This CL appears to have broken the freebsd-amd64-race builder.
See http://build.golang.org/log/cc8fd4b98e6e46b4ace6d351ea6c1b24bcaf9490

Expand All Messages | Collapse All Messages