code review 146580043: cmd/go: sometimes name tmp test binary test.test.exe on...

cmd/go: sometimes name tmp test binary test.test.exe on Windows

Right now it is always pkgname.test.exe, but if pkgname is
patch or install or setup or update, Windows thinks that
running it will install new software, so it pops up a dialog
box asking for more permission.
Renaming the binary avoids the Windows security check.

This only applies to the binary that the Go command writes
to its temporary work directory. If the user runs 'go test -c'
or any of the other ways to generate a test binary, it will
continue to use pkgname.test.exe.

Fixes issue 8711.

[rsc, 2014-09-30 18:00:29]

Hello golang-codereviews@googlegroups.com (cc: bradfitz, brainman, iant, r),

I'd like you to review this change to
https://code.google.com/p/go/

[r, 2014-09-30 18:01:53]

wow

[bradfitz, 2014-09-30 18:05:13]

LGTM but strings.Contains or == ?


On Tue, Sep 30, 2014 at 11:01 AM, <r@golang.org> wrote:

> wow
>
> https://codereview.appspot.com/146580043/
>

[rsc, 2014-09-30 18:21:38]

On Tue, Sep 30, 2014 at 2:05 PM, Brad Fitzpatrick <bradfitz@golang.org>
wrote:

> LGTM but strings.Contains or == ?
>

i don't know; strings.Contains is the conservative choice.
it seems to be completely undocumented. i looked.

[rsc, 2014-09-30 18:30:44]

*** Submitted as https://code.google.com/p/go/source/detail?r=15c0b9f59a61 ***

cmd/go: sometimes name tmp test binary test.test.exe on Windows

Right now it is always pkgname.test.exe, but if pkgname is
patch or install or setup or update, Windows thinks that
running it will install new software, so it pops up a dialog
box asking for more permission.
Renaming the binary avoids the Windows security check.

This only applies to the binary that the Go command writes
to its temporary work directory. If the user runs 'go test -c'
or any of the other ways to generate a test binary, it will
continue to use pkgname.test.exe.

Fixes issue 8711.

LGTM=bradfitz
R=golang-codereviews, r
CC=alex.brainman, bradfitz, golang-codereviews, iant
https://codereview.appspot.com/146580043

[dave_cheney.net, 2014-09-30 23:41:06]

I second that, what a preposterous security anti feature.
On 1 Oct 2014 04:01, <r@golang.org> wrote:

> wow
>
> https://codereview.appspot.com/146580043/
>
> --
> You received this message because you are subscribed to the Google Groups
> "golang-codereviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to golang-codereviews+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>