Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(269)

Issue 146520043: code review 146520043: go/format, cmd/gofmt: added missing comments, minor int... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by gri
Modified:
10 years, 5 months ago
Reviewers:
adonovan
CC:
adonovan, golang-codereviews
Visibility:
Public.

Description

go/format, cmd/gofmt: added missing comments, minor internal cleanup This is a minor cleanup following CL 142360043: The internal parse and format functions in both packages were almost identical - made them identical by adding an extra parameter, and documented them as identical. Eventually we should find a nice way to factor these functions out, but we cannot do this now while in prep for 1.4. No functionality change.

Patch Set 1 #

Patch Set 2 : diff -r 70456f183225fc8faaf381c696b3fd0c9dfd951b https://code.google.com/p/go/ #

Patch Set 3 : diff -r 70456f183225fc8faaf381c696b3fd0c9dfd951b https://code.google.com/p/go/ #

Patch Set 4 : diff -r d5330a8278e5eb84a4ae6edb7e0518308d9b0dd7 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -13 lines) Patch
M src/cmd/gofmt/gofmt.go View 1 2 4 chunks +23 lines, -6 lines 0 comments Download
M src/go/format/format.go View 1 2 4 chunks +29 lines, -7 lines 0 comments Download

Messages

Total messages: 3
gri
Hello adonovan@google.com (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/
10 years, 5 months ago (2014-09-30 00:47:30 UTC) #1
adonovan
On 2014/09/30 00:47:30, gri wrote: > Hello mailto:adonovan@google.com (cc: mailto:golang-codereviews@googlegroups.com), > > I'd like you ...
10 years, 5 months ago (2014-09-30 18:58:49 UTC) #2
gri
10 years, 5 months ago (2014-09-30 19:26:41 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=07bb65448c69 ***

go/format, cmd/gofmt: added missing comments, minor internal cleanup

This is a minor cleanup following CL 142360043:

The internal parse and format functions in both packages
were almost identical - made them identical by adding an
extra parameter, and documented them as identical.

Eventually we should find a nice way to factor these functions
out, but we cannot do this now while in prep for 1.4.

No functionality change.

LGTM=adonovan
R=adonovan
CC=golang-codereviews
https://codereview.appspot.com/146520043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b