Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3998)

Issue 146310043: code review 146310043: cmd/go: fix 'go get vanity/repo/...' in clean GOPATH (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by rsc
Modified:
10 years, 1 month ago
Reviewers:
r
CC:
golang-codereviews, r, iant
Visibility:
Public.

Description

cmd/go: fix 'go get vanity/repo/...' in clean GOPATH The pattern was only working if the checkout had already been done, but the code was trying to make it work even the first time. Test and fix. Fixes issue 8335.

Patch Set 1 #

Patch Set 2 : diff -r b811c3bc6cda5e9140e3774304b7cb1270518d6e https://code.google.com/p/go/ #

Patch Set 3 : diff -r b811c3bc6cda5e9140e3774304b7cb1270518d6e https://code.google.com/p/go/ #

Patch Set 4 : diff -r 8f36a32a9d036f86fb956c8538142eb384bd1a4a https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M src/cmd/go/test.bash View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download
M src/cmd/go/vcs.go View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 3
rsc
Hello golang-codereviews@googlegroups.com (cc: iant, r), I'd like you to review this change to https://code.google.com/p/go/
10 years, 1 month ago (2014-09-25 21:15:06 UTC) #1
r
LGTM
10 years, 1 month ago (2014-09-25 21:20:30 UTC) #2
rsc
10 years, 1 month ago (2014-09-26 16:09:33 UTC) #3
*** Submitted as https://code.google.com/p/go/source/detail?r=39d7b8f3a599 ***

cmd/go: fix 'go get vanity/repo/...' in clean GOPATH

The pattern was only working if the checkout had
already been done, but the code was trying to make
it work even the first time. Test and fix.

Fixes issue 8335.

LGTM=r
R=golang-codereviews, r
CC=golang-codereviews, iant
https://codereview.appspot.com/146310043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b