Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(165)

Issue 14618043: Issue1115 :InstructorFeedbackEdit: Add tooltips

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by victor
Modified:
8 months, 4 weeks ago
Reviewers:
ravenxce
Visibility:
Public.

Description

Issue1115 :InstructorFeedbackEdit: Add tooltips

Patch Set 1 #

Patch Set 2 : Issue1115 : InstructorFeedbackEdit: Add tooltips #

Total comments: 5

Patch Set 3 : Issue1115 :InstructorFeedbackEdit: Add tooltips #

Patch Set 4 : Issue1115 :InstructorFeedbackEdit: Add tooltips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -60 lines) Patch
M src/main/java/teammates/common/util/Const.java View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M src/main/webapp/jsp/instructorFeedbackEdit.jsp View 1 2 8 chunks +22 lines, -12 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackAddSuccess.html View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditEmpty.html View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditPublished.html View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackEditSuccess.html View 1 2 3 2 chunks +6 lines, -6 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionAddSuccess.html View 1 2 3 4 chunks +12 lines, -12 lines 0 comments Download
M src/test/resources/pages/instructorFeedbackQuestionEditSuccess.html View 1 2 3 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 1
ravenxce
10 years, 7 months ago (2013-10-17 08:18:33 UTC) #1
https://codereview.appspot.com/14618043/diff/3001/src/main/java/teammates/com...
File src/main/java/teammates/common/util/Const.java (right):

https://codereview.appspot.com/14618043/diff/3001/src/main/java/teammates/com...
src/main/java/teammates/common/util/Const.java:157: public static final String
VISIBILITY_OPTIONS_RECIPIENT = "Control what feedback recipient(s) can do";
"Do" is misleading, some of the options are for viewing.

https://codereview.appspot.com/14618043/diff/3001/src/main/webapp/jsp/instruc...
File src/main/webapp/jsp/instructorFeedbackEdit.jsp (right):

https://codereview.appspot.com/14618043/diff/3001/src/main/webapp/jsp/instruc...
src/main/webapp/jsp/instructorFeedbackEdit.jsp:10: %>
Add tooltips for the label beside the dropdown selections as well.

(Feedback giver, Feedback Recipient)

https://codereview.appspot.com/14618043/diff/3001/src/main/webapp/jsp/instruc...
src/main/webapp/jsp/instructorFeedbackEdit.jsp:333: <th>Can see answer</th>
Tooltip for this?

https://codereview.appspot.com/14618043/diff/3001/src/main/webapp/jsp/instruc...
src/main/webapp/jsp/instructorFeedbackEdit.jsp:337: <tr
onmouseover="ddrivetip('<%=Const.Tooltips.VISIBILITY_OPTIONS_RECIPIENT%>')"
Move the tooltips into just the first <td> cell so the tooltip will not block
the checkboxes.

https://codereview.appspot.com/14618043/diff/3001/src/main/webapp/jsp/instruc...
src/main/webapp/jsp/instructorFeedbackEdit.jsp:462: <th>Can see answer</th>
Tooltips for these?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b