Issue 14609043: state/apiserver: don't log Pings

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14609043: state/apiserver: don't log Pings

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
mue, natefinch, mp+190596

Visibility:
Public.

Description

state/apiserver: don't log Pings This will remove a fair amount of log file noise. https://code.launchpad.net/~rogpeppe/juju-core/448-rpc-log-no-ping/+merge/190596 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : state/apiserver: don't log Pings #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+151 lines, -34 lines)			Patch
A	[revision details]	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	rpc/jsoncodec/codec.go	View	2 chunks	+40 lines, -22 lines	2 comments	Download
M	rpc/jsoncodec/codec_test.go	View	5 chunks	+60 lines, -4 lines	0 comments	Download
M	state/apiserver/apiserver.go	View	5 chunks	+35 lines, -5 lines	0 comments	Download
M	state/apiserver/pinger_test.go	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	state/apiserver/root.go	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

natefinch

On 2013/10/11 10:31:57, rog wrote: > Please take a look. LGTM

10 years, 7 months ago (2013-10-11 10:41:11 UTC) #2

mue

LGTM, like that approach. Only one small question. https://codereview.appspot.com/14609043/diff/3001/rpc/jsoncodec/codec.go File rpc/jsoncodec/codec.go (right): https://codereview.appspot.com/14609043/diff/3001/rpc/jsoncodec/codec.go#newcode183 rpc/jsoncodec/codec.go:183: func ...

10 years, 7 months ago (2013-10-11 10:49:13 UTC) #3

rog

10 years, 7 months ago (2013-10-11 12:08:09 UTC) #4

https://codereview.appspot.com/14609043/diff/3001/rpc/jsoncodec/codec.go
File rpc/jsoncodec/codec.go (right):

https://codereview.appspot.com/14609043/diff/3001/rpc/jsoncodec/codec.go#newc...
rpc/jsoncodec/codec.go:183: func (m *outMsg) init(hdr *rpc.Header, body
interface{}) {
On 2013/10/11 10:49:14, mue wrote:
> Why no constructor returning the message? I only have seen it immediately
after
> a 
> 
> var m outMsg
> 
> so far, maybe I've missed one.

Yeah, we could do that. I was thinking that by avoiding returning
it we might avoid an allocation, but passing the pointer to c.conn.Send
will mark it as escaping anyway, so that won't help.

Expand All Messages | Collapse All Messages