Issue 14601045: code review 14601045: goprotobuf: Remove MarshalJSON methods from generated e...

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14601045: code review 14601045: goprotobuf: Remove MarshalJSON methods from generated e... (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by dsymonds

Modified:
12 years, 1 month ago

Reviewers:
r

CC:
r, golang-dev

Visibility:
Public.

Description

goprotobuf: Remove MarshalJSON methods from generated enum types. This will results in JSON output using numbers for enum values, which is consistent with the default behaviour of other languages. UnmarshalJSON is left to handle both numeric and symbolic values.

Patch Set 1 #

Patch Set 2 : diff -r 7fd1f2744e3c https://code.google.com/p/goprotobuf #

Patch Set 3 : diff -r 7fd1f2744e3c https://code.google.com/p/goprotobuf #

Patch Set 4 : diff -r 7fd1f2744e3c https://code.google.com/p/goprotobuf #

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -63 lines)			Patch
M	proto/all_test.go	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	proto/lib.go	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	proto/testdata/test.pb.go	View	1	5 chunks	+0 lines, -15 lines	0 comments	Download
M	protoc-gen-go/descriptor/descriptor.pb.go	View	1	4 chunks	+0 lines, -12 lines	0 comments	Download
M	protoc-gen-go/generator/generator.go	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go	View	1	4 chunks	+0 lines, -12 lines	0 comments	Download
M	protoc-gen-go/testdata/my_test/test.pb.go.golden	View	1	4 chunks	+0 lines, -12 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

dsymonds

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/goprotobuf

12 years, 1 month ago (2013-10-10 22:12:09 UTC) #1

dsymonds

12 years, 1 month ago (2013-10-10 23:08:42 UTC) #3

*** Submitted as
https://code.google.com/p/goprotobuf/source/detail?r=61664b8425f3 ***

goprotobuf: Remove MarshalJSON methods from generated enum types.

This will results in JSON output using numbers for enum values, which
is consistent with the default behaviour of other languages.
UnmarshalJSON is left to handle both numeric and symbolic values.

R=r
CC=golang-dev
https://codereview.appspot.com/14601045

Expand All Messages | Collapse All Messages