Issue 14595045: Added the source code tab to bundle details view

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14595045: Added the source code tab to bundle details view

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by jeff.pihach

Modified:
10 years, 6 months ago

Reviewers:
mp+190269, gary.poster

Visibility:
Public.

Description

Added the source code tab to bundle details view https://code.launchpad.net/~hatch/juju-gui/bundle-source-view/+merge/190269 (do not edit description out of merge proposal)

Patch Set 2 : Added the source code tab to bundle details view #

Patch Set 3 : Added the source code tab to bundle details view #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+113 lines, -46 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	app/subapps/browser/views/bundle.js	View	1 2	2 chunks	+8 lines, -3 lines	0 comments	Download
M	app/subapps/browser/views/charm.js	View		1 chunk	+0 lines, -19 lines	0 comments	Download
M	app/subapps/browser/views/entity-base.js	View		1 chunk	+19 lines, -0 lines	0 comments	Download
M	app/templates/bundle.handlebars	View	1 2	2 chunks	+26 lines, -0 lines	0 comments	Download
M	test/test_bundle_details_view.js	View	1 2	5 chunks	+58 lines, -24 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

gary.poster

Nice tests. LGTM with additional text I mention. qa good. Thank you! https://codereview.appspot.com/14595045/diff/1/app/subapps/browser/views/charm.js File app/subapps/browser/views/charm.js ...

10 years, 6 months ago (2013-10-10 00:06:42 UTC) #2

jeff.pihach

Thanks for the review! https://codereview.appspot.com/14595045/diff/1/app/templates/bundle.handlebars File app/templates/bundle.handlebars (right): https://codereview.appspot.com/14595045/diff/1/app/templates/bundle.handlebars#newcode145 app/templates/bundle.handlebars:145: </p> On 2013/10/10 00:06:42, gary.poster ...

10 years, 6 months ago (2013-10-10 04:37:26 UTC) #3

jeff.pihach

10 years, 6 months ago (2013-10-10 04:53:42 UTC) #4

*** Submitted:

Added the source code tab to bundle details view

R=gary.poster
CC=
https://codereview.appspot.com/14595045

Expand All Messages | Collapse All Messages