Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(465)

Issue 14591045: Vertex Color Baking

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 5 months ago by psy-fi
Modified:
10 years, 5 months ago
Reviewers:
sergey.vfx, brechtvl
Base URL:
https://svn.blender.org/svnroot/bf-blender/trunk/blender/
Visibility:
Public.

Description

This patch adds support for vertex color baking to image textures. It is written in anticipation of multires support for vertex colors but also to enable some effects through textures that are not possible now (For instance baking per vertex dirt maps)

Patch Set 1 #

Patch Set 2 : Rebase against 60655 and better parenthesis #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -11 lines) Patch
source/blender/makesrna/intern/rna_scene.c View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/render/extern/include/RE_pipeline.h View 1 1 chunk +2 lines, -1 line 0 comments Download
source/blender/render/intern/include/render_types.h View 1 1 chunk +1 line, -0 lines 0 comments Download
source/blender/render/intern/source/bake.c View 1 2 chunks +8 lines, -1 line 1 comment Download
source/blender/render/intern/source/convertblender.c View 1 3 chunks +8 lines, -4 lines 0 comments Download
source/blender/render/intern/source/shadeinput.c View 1 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6
psy-fi
10 years, 5 months ago (2013-10-09 23:13:08 UTC) #1
psy-fi
Rebase against 60655 and better parenthesis
10 years, 5 months ago (2013-10-10 10:42:13 UTC) #2
sergey.vfx
LGTM.
10 years, 5 months ago (2013-10-10 10:50:17 UTC) #3
brechtvl
https://codereview.appspot.com/14591045/diff/22001/source/blender/render/intern/source/bake.c File source/blender/render/intern/source/bake.c (right): https://codereview.appspot.com/14591045/diff/22001/source/blender/render/intern/source/bake.c#newcode268 source/blender/render/intern/source/bake.c:268: shr.alpha = 1.0; Vertex colors have an alpha channel ...
10 years, 5 months ago (2013-10-10 12:39:46 UTC) #4
brechtvl
10 years, 5 months ago (2013-10-10 12:39:47 UTC) #5
psy-fi
10 years, 5 months ago (2013-10-10 12:52:03 UTC) #6
On 2013/10/10 12:39:46, brechtvl wrote:
>
https://codereview.appspot.com/14591045/diff/22001/source/blender/render/inte...
> File source/blender/render/intern/source/bake.c (right):
> 
>
https://codereview.appspot.com/14591045/diff/22001/source/blender/render/inte...
> source/blender/render/intern/source/bake.c:268: shr.alpha = 1.0;
> Vertex colors have an alpha channel now with dynamic paint, so it should bake
> the alpha for that. See this bug report for an example file:
>
https://projects.blender.org/tracker/index.php?func=detail&aid=36832&group_id...

Ah, OK, initially when I wrote this it wasn't working so I enforced alpha as
1.0. Retesting this now seems OK so most probably I did a mistake back then.
Fixed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b