Adds charm icons to bundle token and detail view

Adds charm icons to bundle token and detail view



https://code.launchpad.net/~hatch/juju-gui/show-bundle-charm-tokens/+merge/190260

(do not edit description out of merge proposal)

[jeff.pihach, 2013-10-09 22:28:36]

Please take a look.

[gary.poster, 2013-10-09 23:54:01]

conditional LGTM on filtering out the non-approved charms, per below.

https://codereview.appspot.com/14591044/diff/1/app/subapps/browser/views/bund...
File app/subapps/browser/views/bundle.js (right):

https://codereview.appspot.com/14591044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:130: attrs.charmIcons =
utils.charmIconParser(attrs.charm_metadata);
Cool.  Does this populate a cache?  Would be nice.

https://codereview.appspot.com/14591044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:164: then(null, this.apiFailure.bind(this));
why did you do this, rather than simply break the paren accross the line? 
<shrug> but curious.

https://codereview.appspot.com/14591044/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/14591044/diff/1/app/views/utils.js#newcode1671
app/views/utils.js:1671: // Sort the approved charm icons to appear first.
Actually we are supposed to filter out non-approved charms from these.  Don't
put them last; instead, exclude them.

[jeff.pihach, 2013-10-10 04:24:46]

Thanks for the review - fixes incoming

https://codereview.appspot.com/14591044/diff/1/app/subapps/browser/views/bund...
File app/subapps/browser/views/bundle.js (right):

https://codereview.appspot.com/14591044/diff/1/app/subapps/browser/views/bund...
app/subapps/browser/views/bundle.js:164: then(null, this.apiFailure.bind(this));
This was actually the fix (The one Ben was talking about) to the issue I've been
fighting with, I had the syntax wrong for the promise 'catchall' in my head.
You'll notice that I added another then() which has only a reject handler to
capture all failures from all three promises. The way it was before it was only
catching the failures from the first two.

https://codereview.appspot.com/14591044/diff/1/app/views/utils.js
File app/views/utils.js (right):

https://codereview.appspot.com/14591044/diff/1/app/views/utils.js#newcode1671
app/views/utils.js:1671: // Sort the approved charm icons to appear first.
Oops, I'll fix that.

[jeff.pihach, 2013-10-10 04:38:52]

*** Submitted:

Adds charm icons to bundle token and detail view

R=gary.poster
CC=
https://codereview.appspot.com/14591044