Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1584)

Issue 145910043: code review 145910043: x509: implement crypto.Signer (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years ago by Paul van Brouwershaven
Modified:
6 years, 8 months ago
Reviewers:
CC:
agl, agl1, bradfitz, golang-codereviews
Visibility:
Public.

Description

x509: implement crypto.Signer Signer is an interface to support opaque private keys. These keys typically result from being kept in special hardware (i.e. a TPM) although sometimes operating systems provide a similar interface using process isolation for security rather than hardware boundaries. This changes provides updates implements crypto.Signer in CreateCRL and CreateCertificate so that they can be used with opaque keys.

Patch Set 1 #

Patch Set 2 : diff -r 6b163ec2122a172030284060788f535ab3b9d0e3 https://code.google.com/p/go #

Patch Set 3 : diff -r 6b163ec2122a172030284060788f535ab3b9d0e3 https://code.google.com/p/go #

Total comments: 14

Patch Set 4 : diff -r 6b163ec2122a172030284060788f535ab3b9d0e3 https://code.google.com/p/go #

Total comments: 12

Patch Set 5 : diff -r f60b128afd41217fa34662a5cbe1eb0b8c546e71 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -68 lines) Patch
M src/crypto/x509/x509.go View 1 2 3 4 10 chunks +48 lines, -68 lines 0 comments Download

Messages

Total messages: 9
agl
https://codereview.appspot.com/145910043/diff/40001/src/crypto/x509/x509.go File src/crypto/x509/x509.go (right): https://codereview.appspot.com/145910043/diff/40001/src/crypto/x509/x509.go#newcode1388 src/crypto/x509/x509.go:1388: err = errors.New("x509: only RSA and ECDSA public keys ...
7 years ago (2014-09-18 17:33:24 UTC) #1
Paul van Brouwershaven
https://codereview.appspot.com/145910043/diff/40001/src/crypto/x509/x509.go File src/crypto/x509/x509.go (right): https://codereview.appspot.com/145910043/diff/40001/src/crypto/x509/x509.go#newcode1388 src/crypto/x509/x509.go:1388: err = errors.New("x509: only RSA and ECDSA public keys ...
7 years ago (2014-09-18 18:11:59 UTC) #2
Paul van Brouwershaven
https://codereview.appspot.com/145910043/diff/40001/src/crypto/x509/x509.go File src/crypto/x509/x509.go (right): https://codereview.appspot.com/145910043/diff/40001/src/crypto/x509/x509.go#newcode1664 src/crypto/x509/x509.go:1664: func CreateCertificateRequest(rand io.Reader, template *CertificateRequest, priv interface{}) (csr []byte, ...
7 years ago (2014-09-18 20:08:33 UTC) #3
Paul van Brouwershaven
https://codereview.appspot.com/145910043/diff/40001/src/crypto/x509/x509.go File src/crypto/x509/x509.go (right): https://codereview.appspot.com/145910043/diff/40001/src/crypto/x509/x509.go#newcode1388 src/crypto/x509/x509.go:1388: err = errors.New("x509: only RSA and ECDSA public keys ...
7 years ago (2014-09-18 20:22:12 UTC) #4
agl1
(Note: this might have to wait until after 1.4 to land.) https://codereview.appspot.com/145910043/diff/4/src/crypto/x509/x509.go File src/crypto/x509/x509.go (right): ...
7 years ago (2014-09-22 22:10:09 UTC) #5
Paul van Brouwershaven
https://codereview.appspot.com/145910043/diff/4/src/crypto/x509/x509.go File src/crypto/x509/x509.go (right): https://codereview.appspot.com/145910043/diff/4/src/crypto/x509/x509.go#newcode1435 src/crypto/x509/x509.go:1435: // All keys types that are implemented via crypto.Signer ...
7 years ago (2014-09-23 11:13:05 UTC) #6
Paul van Brouwershaven
Hello agl@chromium.org, agl@golang.org (cc: bradfitz@golang.org, golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
6 years, 10 months ago (2014-11-14 16:28:34 UTC) #7
agl1
I think that this is probably good, but would still need to wait until after ...
6 years, 10 months ago (2014-11-14 18:46:22 UTC) #8
gobot
6 years, 9 months ago (2014-12-19 05:13:37 UTC) #9
R=close

To the author of this CL:

The Go project has moved to Gerrit Code Review.

If this CL should be continued, please see the latest version of
https://golang.org/doc/contribute.html for instructions on
how to set up Git and the Go project's Gerrit codereview plugin,
and then create a new change with your current code.

If there has been discussion on this CL, please give a link to it
(golang.org/cl/145910043 is best) in the description in your
new CL.

Thanks very much.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b