Issue 14589043: code review 14589043: go.tools/pointer: support reflect.Method{,ByName}.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14589043: code review 14589043: go.tools/pointer: support reflect.Method{,ByName}. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by adonovan

Modified:
12 years ago

Reviewers:
crawshaw1

CC:
crawshaw1, golang-dev

Visibility:
Public.

Description

go.tools/pointer: support reflect.Method{,ByName}.

Patch Set 1 #

Patch Set 2 : diff -r 415c26b62c8c https://code.google.com/p/go.tools #

Patch Set 3 : diff -r 415c26b62c8c https://code.google.com/p/go.tools #

Patch Set 4 : diff -r e7f84321b325 https://code.google.com/p/go.tools #

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+136 lines, -2 lines)			Patch
	M	pointer/reflect.go	View	1	1 chunk	+97 lines, -2 lines	0 comments	Download
	M	pointer/testdata/funcreflect.go	View	1 2 3	1 chunk	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adonovan

Hello crawshaw@google.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.tools

12 years ago (2013-10-09 19:01:17 UTC) #1

adonovan

12 years ago (2013-10-09 20:36:02 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=1d462abd2860&repo=tools ***

go.tools/pointer: support reflect.Method{,ByName}.

R=crawshaw
CC=golang-dev
https://codereview.appspot.com/14589043

Expand All Messages | Collapse All Messages