Issue 14588043: code review 14588043: go.net/ipv4: simplify protocol constants generator

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14588043: code review 14588043: go.net/ipv4: simplify protocol constants generator (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by mikio

Modified:
10 years, 6 months ago

Reviewers:
dfc

CC:
golang-dev, dfc

Visibility:
Public.

Description

go.net/ipv4: simplify protocol constants generator Also updates IANA protocol constants.

Patch Set 1 : diff -r 694435acecf9 https://code.google.com/p/go.net #

Patch Set 2 : diff -r 694435acecf9 https://code.google.com/p/go.net #

Patch Set 3 : diff -r 694435acecf9 https://code.google.com/p/go.net #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+45 lines, -52 lines)			Patch
M	ipv4/gen.go	View	2 chunks	+20 lines, -26 lines	0 comments	Download
M	ipv4/gentest.go	View	3 chunks	+23 lines, -24 lines	0 comments	Download
M	ipv4/iana_test.go	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

mikio

Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.net

10 years, 6 months ago (2013-10-09 19:01:41 UTC) #1

dfc

On 2013/10/09 19:01:41, mikio wrote: > Hello mailto:golang-dev@googlegroups.com (cc: mailto:golang-dev@googlegroups.com), > > I'd like you ...

10 years, 6 months ago (2013-10-14 00:09:16 UTC) #2

mikio

10 years, 6 months ago (2013-10-14 00:29:47 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=5c52d6bf9235&repo=net ***

go.net/ipv4: simplify protocol constants generator

Also updates IANA protocol constants.

R=golang-dev, dave
CC=golang-dev
https://codereview.appspot.com/14588043

Expand All Messages | Collapse All Messages