Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(936)

Issue 14575043: code review 14575043: debug/dwarf: handle surprising clang encoding (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 7 months ago by rsc
Modified:
12 years, 7 months ago
Reviewers:
iant
CC:
golang-dev, iant
Visibility:
Public.

Description

debug/dwarf: handle surprising clang encoding Fixes a bug in cgo on OS X using clang. See golang.org/issue/6472 for details. Fixes issue 6472.

Patch Set 1 #

Patch Set 2 : diff -r f543981e96da https://code.google.com/p/go/ #

Patch Set 3 : diff -r f543981e96da https://code.google.com/p/go/ #

Patch Set 4 : diff -r f543981e96da https://code.google.com/p/go/ #

Total comments: 1

Patch Set 5 : diff -r 1e39b9482377 https://code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -12 lines) Patch
A misc/cgo/test/issue6472.go View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M src/pkg/debug/dwarf/type.go View 1 1 chunk +31 lines, -12 lines 0 comments Download

Messages

Total messages: 4
rsc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go/
12 years, 7 months ago (2013-10-09 01:03:15 UTC) #1
iant
LGTM https://codereview.appspot.com/14575043/diff/7001/misc/cgo/test/issue6472.go File misc/cgo/test/issue6472.go (right): https://codereview.appspot.com/14575043/diff/7001/misc/cgo/test/issue6472.go#newcode5 misc/cgo/test/issue6472.go:5: package cgotest Do we need //+build cgo ?
12 years, 7 months ago (2013-10-09 14:07:01 UTC) #2
rsc
no +build; we only build that directory to run the cgo tests. none of the ...
12 years, 7 months ago (2013-10-09 15:08:00 UTC) #3
rsc
12 years, 7 months ago (2013-10-09 15:08:26 UTC) #4
*** Submitted as https://code.google.com/p/go/source/detail?r=71051fea795a ***

debug/dwarf: handle surprising clang encoding

Fixes a bug in cgo on OS X using clang.
See golang.org/issue/6472 for details.

Fixes issue 6472.

R=golang-dev, iant
CC=golang-dev
https://codereview.appspot.com/14575043
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b