Issue 145680044: code review 145680044: encoding/json: don't panic on incorrect map argument

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 145680044: code review 145680044: encoding/json: don't panic on incorrect map argument (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 5 months ago by gri

Modified:
10 years, 5 months ago

Reviewers:
gobot, rsc

CC:
rsc, golang-codereviews

Visibility:
Public.

Description

encoding/json: don't panic on incorrect map argument Fixes issue 8305.

Patch Set 1 #

Patch Set 2 : diff -r fc88ef583e2155e896b331630fde15bd7dcf8d02 https://code.google.com/p/go/ #

Patch Set 3 : diff -r fc88ef583e2155e896b331630fde15bd7dcf8d02 https://code.google.com/p/go/ #

Patch Set 4 : diff -r 5fe7df08d177785478673c9c69f5a568268c73b1 https://code.google.com/p/go/ #

Created: 10 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	src/encoding/json/decode.go	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
	M	src/encoding/json/decode_test.go	View	1	3 chunks	+11 lines, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

gri

Hello rsc@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go/

10 years, 5 months ago (2014-10-01 23:00:18 UTC) #1

gri

*** Submitted as https://code.google.com/p/go/source/detail?r=0cc9f49292a7 *** encoding/json: don't panic on incorrect map argument Fixes issue 8305. ...

10 years, 5 months ago (2014-10-01 23:24:20 UTC) #3

gobot

This CL appears to have broken the netbsd-amd64-bsiegert builder. See http://build.golang.org/log/d1a5aa60a956a8eb8c7034894adc3e4a33c2d2ab

10 years, 5 months ago (2014-10-02 21:29:04 UTC) #4

gobot

10 years, 5 months ago (2014-10-02 23:19:30 UTC) #5

Message was sent while issue was closed.

This changed caused perf changes on windows-amd64-perf:


json-1                    old          new      delta
cputime             176250000    171250000      -2.84
time                176118808    171314476      -2.73

json-2                    old          new      delta
cputime             179062500    172968750      -3.40
time                 89921083     87008456      -3.24

json-4                    old          new      delta
cputime             180859375    175703125      -2.85
time                 46016493     44455086      -3.39

json-8                    old          new      delta
cputime             190343750    185000000      -2.81
time                 24598179     23857513      -3.01

http://build.golang.org/perfdetail?commit=0cc9f49292a7e63727bc9afb3883abdc4c5...



—gobot

Expand All Messages | Collapse All Messages