Issue 14566049: code review 14566049: go.tools/misc/dist: copy doc.go from go.tools to go root

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14566049: code review 14566049: go.tools/misc/dist: copy doc.go from go.tools to go root (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by adg

Modified:
11 years, 6 months ago

Reviewers:
dsymonds

CC:
r, dsymonds, golang-dev

Visibility:
Public.

Description

go.tools/misc/dist: copy doc.go from go.tools to go root This will allow "godoc godoc", "godoc vet", "godoc cover" to work. Fixes issue 6527.

Patch Set 2 : diff -r 5f680cab75f6 https://code.google.com/p/go #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
	M	misc/dist/bindist.go	View	1	3 chunks	+27 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

adg

Hello r (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go

11 years, 6 months ago (2013-10-11 00:35:23 UTC) #1

dsymonds

LGTM https://codereview.appspot.com/14566049/diff/1/misc/dist/bindist.go File misc/dist/bindist.go (right): https://codereview.appspot.com/14566049/diff/1/misc/dist/bindist.go#newcode503 misc/dist/bindist.go:503: if err := ioutil.WriteFile(docGo, d, 0666); err != ...

11 years, 6 months ago (2013-10-11 01:12:31 UTC) #2

adg

11 years, 6 months ago (2013-10-11 01:37:39 UTC) #3

*** Submitted as https://code.google.com/p/go/source/detail?r=84f56bb7013a ***

go.tools/misc/dist: copy doc.go from go.tools to go root

This will allow "godoc godoc", "godoc vet", "godoc cover" to work.

Fixes issue 6527.

R=r, dsymonds
CC=golang-dev
https://codereview.appspot.com/14566049

https://codereview.appspot.com/14566049/diff/1/misc/dist/bindist.go
File misc/dist/bindist.go (right):

https://codereview.appspot.com/14566049/diff/1/misc/dist/bindist.go#newcode503
misc/dist/bindist.go:503: if err := ioutil.WriteFile(docGo, d, 0666); err != nil
{
On 2013/10/11 01:12:31, dsymonds wrote:
> I would have expected 0755 and 0644, but I assume you've thought it out more
> than me.

Actually, no. It was just a mistake on my part. Fixed.

Expand All Messages | Collapse All Messages