Issue 14566047: code review 14566047: freetype/truetype: speed up the testScaling test function.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14566047: code review 14566047: freetype/truetype: speed up the testScaling test function. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 8 months ago by nigeltao

Modified:
10 years, 8 months ago

Reviewers:
bsiegert

CC:
bsiegert, golang-dev

Visibility:
Public.

Description

freetype/truetype: speed up the testScaling test function. "go test" drops from 5.203s to 0.474s.

Patch Set 1 #

Patch Set 2 : diff -r 10b39e74df10 https://code.google.com/p/freetype-go #

Patch Set 3 : diff -r 10b39e74df10 https://code.google.com/p/freetype-go #

Patch Set 4 : diff -r c8114d24b050 https://code.google.com/p/freetype-go #

Total comments: 1

Patch Set 5 : diff -r c8114d24b050 https://code.google.com/p/freetype-go #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -17 lines)			Patch
	M	freetype/truetype/truetype_test.go	View	1 2 3	4 chunks	+58 lines, -17 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

nigeltao

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/freetype-go

10 years, 8 months ago (2013-10-10 20:49:50 UTC) #1

bsiegert

LGTM I like handwritten parsers :) Sorry for the delay in reviewing this, it fell ...

10 years, 8 months ago (2013-10-12 10:50:54 UTC) #2

nigeltao

10 years, 8 months ago (2013-10-13 04:47:22 UTC) #3

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=26f9f30bca9c ***

freetype/truetype: speed up the testScaling test function.

"go test" drops from 5.203s to 0.474s.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/14566047

Expand All Messages | Collapse All Messages