Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1808)

Issue 145490043: Roman string numbers (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by Valentin Villenave
Modified:
4 years, 8 months ago
Reviewers:
pkx166h
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Make string numbers more versatile This commit adds a number-type property that allows for different numbering styles, as well as user-exposed predefined commands to easily switch between default guitar-like string numbers and roman numerals more suitable for unfretted strings. Additionally, the number formatting function previously used only in fret-diagrams, is now available for possibly wider use.

Patch Set 1 #

Total comments: 7

Patch Set 2 : Doc improvements #

Patch Set 3 : Compile fix #

Patch Set 4 : Define a separate number-interface #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -18 lines) Patch
M Documentation/changes.tely View 1 1 chunk +11 lines, -0 lines 0 comments Download
M Documentation/notation/fretted-strings.itely View 1 2 chunks +20 lines, -0 lines 0 comments Download
M Documentation/notation/unfretted-strings.itely View 1 3 chunks +15 lines, -4 lines 0 comments Download
A input/regression/string-number-styles.ly View 1 chunk +20 lines, -0 lines 0 comments Download
M ly/property-init.ly View 1 chunk +16 lines, -0 lines 0 comments Download
M scm/define-grob-interfaces.scm View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +2 lines, -0 lines 0 comments Download
M scm/define-grobs.scm View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M scm/fret-diagrams.scm View 1 chunk +3 lines, -13 lines 0 comments Download
M scm/lily-library.scm View 1 2 3 1 chunk +20 lines, -0 lines 0 comments Download
M scm/output-lib.scm View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8
Valentin Villenave
Greetings everybody, here's a thought: the shorthand syntax for string numbers is so useful that ...
4 years, 9 months ago (2014-09-28 22:43:41 UTC) #1
pkx166h
Welcome back Valentine! P.S. don't forget to update the google tracker (if not using git-cl) ...
4 years, 9 months ago (2014-09-29 06:30:27 UTC) #2
pkx166h
:) Sorry. Some more tightening of the text. https://codereview.appspot.com/145490043/diff/1/Documentation/notation/fretted-strings.itely File Documentation/notation/fretted-strings.itely (right): https://codereview.appspot.com/145490043/diff/1/Documentation/notation/fretted-strings.itely#newcode127 Documentation/notation/fretted-strings.itely:127: than ...
4 years, 9 months ago (2014-09-29 06:32:22 UTC) #3
Valentin Villenave
Doc improvements
4 years, 9 months ago (2014-09-29 07:02:58 UTC) #4
Valentin Villenave
Thanks James, since I've been living under a rock for some time, I wasn't aware ...
4 years, 9 months ago (2014-09-29 07:05:27 UTC) #5
pkx166h
Fails make: --snip-- [/tmp/lilypond-autobuild/ly/generate-documentation.ly [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/documentation-lib.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily-sort.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-functions.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-translation.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-music.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-type-predicates.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-identifiers.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-context-mods.scm] [/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-backend.scm fatal error: ...
4 years, 9 months ago (2014-09-29 07:22:51 UTC) #6
Valentin Villenave
Compile fix
4 years, 9 months ago (2014-09-29 07:59:35 UTC) #7
Valentin Villenave
4 years, 8 months ago (2014-09-30 21:45:19 UTC) #8
Define a separate number-interface
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b