Roman string numbers

Make string numbers more versatile

This commit adds a number-type property that
allows for different numbering styles, as
well as user-exposed predefined commands
to easily switch between default guitar-like
string numbers and roman numerals more suitable
for unfretted strings.

Additionally, the number formatting function
previously used only in fret-diagrams, is now
available for possibly wider use.

[Valentin Villenave, 2014-09-28 22:43:41]

Greetings everybody,

here's a thought: the shorthand syntax for string numbers is so useful that it
shouldn't be limited to fretted strings, but could also come handy for unfretted
strings notation.  This is the less dirty way I could find of making that
happen.

(Sidebar: When adding the \romanStringNumbers shorthand, I tried to include
something in the way of placing the roman-numered string indications below the
staff rather than above. But I couldn't find a way of doing that without
completely resetting the stringNumberOrientations context property (which I
can't access at this point, even less "stash" somewhere so it could be reverted
down the line). If someone has an idea or if I'm doing this wrong, please let me
know.)

[pkx166h, 2014-09-29 06:30:27]

Welcome back Valentine!

P.S. don't forget to update the google tracker (if not using git-cl) - Patch-New
means the patch gets automatic testing.

https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:65: (e.g. for unfretted string instruments).
'String numbers can now be printed using Roman numerals.'

Could we get a small @lilypond example here?

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/frette...
File Documentation/notation/fretted-strings.itely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/frette...
Documentation/notation/fretted-strings.itely:127: than above.
This has some awkward syntax. I suggest:

The default number style, as is customary with unfretted strings, can be printed
in Roman numerals and can also be placed below the staff rather than above.

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/unfret...
File Documentation/notation/unfretted-strings.itely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/unfret...
Documentation/notation/unfretted-strings.itely:118: 
This could be reduced slightly (and possibly spilt into two paras):

'Roman rather than the default circled Arabic numerals can be added as strings
numbers.  See @ref{String number indications}.

Alternatively, open strings can be indicated by using markup commands with
articulation scripts.'

[pkx166h, 2014-09-29 06:32:22]

:) Sorry. Some more tightening of the text.

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/frette...
File Documentation/notation/fretted-strings.itely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/frette...
Documentation/notation/fretted-strings.itely:127: than above.
On 2014/09/29 06:30:27, J_lowe wrote:
> This has some awkward syntax. I suggest:
> 
> The default number style, as is customary with unfretted strings, can be
printed
> in Roman numerals and can also be placed below the staff rather than above.

'The default number style, as is customary with unfretted strings, can be
printed in Roman numerals and placed below the staff rather than above.'

[Valentin Villenave, 2014-09-29 07:02:58]

Doc improvements

[Valentin Villenave, 2014-09-29 07:05:27]

Thanks James,
since I've been living under a rock for some time, I wasn't aware of the Google
tracker/Rietveld integration. Thanks Colin!

I've slightly reworded your suggestions but hopefully this will be both concise
and clear.

https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/changes.tely#ne...
Documentation/changes.tely:65: (e.g. for unfretted string instruments).
On 2014/09/29 06:30:27, J_lowe wrote:
> 'String numbers can now be printed using Roman numerals.'
> 
> Could we get a small @lilypond example here?

Done.

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/frette...
File Documentation/notation/fretted-strings.itely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/frette...
Documentation/notation/fretted-strings.itely:127: than above.
On 2014/09/29 06:30:27, J_lowe wrote:
> This has some awkward syntax. I suggest:
> 
> The default number style, as is customary with unfretted strings, can be
printed
> in Roman numerals and can also be placed below the staff rather than above.

Done.

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/unfret...
File Documentation/notation/unfretted-strings.itely (right):

https://codereview.appspot.com/145490043/diff/1/Documentation/notation/unfret...
Documentation/notation/unfretted-strings.itely:118: 
On 2014/09/29 06:30:27, J_lowe wrote:
> This could be reduced slightly (and possibly spilt into two paras):
> 
> 'Roman rather than the default circled Arabic numerals can be added as strings
> numbers.  See @ref{String number indications}.
> 
> Alternatively, open strings can be indicated by using markup commands with
> articulation scripts.'
> 

Done.

[pkx166h, 2014-09-29 07:22:51]

Fails make:

--snip--

 [/tmp/lilypond-autobuild/ly/generate-documentation.ly
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/documentation-lib.scm]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily-sort.scm]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-functions.scm]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-translation.scm]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-music.scm]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-type-predicates.scm]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-identifiers.scm]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-context-mods.scm]
[/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/document-backend.scm
fatal error: define-grob-properties.scm: cannot find interface for property:
number-type
/tmp/build-lilypond-autobuild/out/share/lilypond/current/scm/lily.scm

--snip--

[Valentin Villenave, 2014-09-29 07:59:35]

Compile fix

[Valentin Villenave, 2014-09-30 21:45:19]

Define a separate number-interface