Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2524)

Issue 14548050: Fix Go sandbox AllWatcher initialization

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 6 months ago by gary.poster
Modified:
10 years, 6 months ago
Reviewers:
mp+190685, matthew.scott
Visibility:
Public.

Description

Fix Go sandbox AllWatcher initialization The Go sandbox AllWatcher was trying to send deltas immediately, which does not match the juju core implementation. This fixes the behavior, with a test. It also fixes a user-visible bug. To qa, turn off the simulator in the config file, and then deploy a service in the default go sandbox. Before my branch, the unit would never appear, because the delta for this change was lost. After my branch, the unit appears correctly. https://code.launchpad.net/~gary/juju-gui/fixGoSandboxWatcher2/+merge/190685 (do not edit description out of merge proposal)

Patch Set 1 #

Patch Set 2 : Fix Go sandbox AllWatcher initialization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
A [revision details] View 1 chunk +2 lines, -0 lines 0 comments Download
M app/store/env/sandbox.js View 1 chunk +4 lines, -4 lines 0 comments Download
M test/test_sandbox_go.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4
gary.poster
Please take a look.
10 years, 6 months ago (2013-10-11 14:26:19 UTC) #1
matthew.scott
LGTM, thanks for catching this!
10 years, 6 months ago (2013-10-11 14:29:25 UTC) #2
gary.poster
*** Submitted: Fix Go sandbox AllWatcher initialization The Go sandbox AllWatcher was trying to send ...
10 years, 6 months ago (2013-10-11 14:44:46 UTC) #3
gary.poster
10 years, 6 months ago (2013-10-11 15:23:53 UTC) #4
On 2013/10/11 14:29:25, matthew.scott wrote:
> LGTM, thanks for catching this!

Thanks, Matt!
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b