code review 14548046: freetype/truetype: parse UCS-4 encoded cmap tables.

freetype/truetype: parse UCS-4 encoded cmap tables.

[nigeltao, 2013-10-10 09:11:13]

Hello bsiegert@gmail.com (cc: golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/freetype-go

[bsiegert, 2013-10-10 11:46:32]

https://codereview.appspot.com/14548046/diff/4001/freetype/truetype/truetype_...
File freetype/truetype/truetype_test.go (right):

https://codereview.appspot.com/14548046/diff/4001/freetype/truetype/truetype_...
freetype/truetype/truetype_test.go:79: "luxisr": map[rune]Index{
Can you omit the type name here?

https://codereview.appspot.com/14548046/diff/4001/freetype/truetype/truetype_...
freetype/truetype/truetype_test.go:159: b, err :=
ioutil.ReadFile(fmt.Sprintf("../../testdata/%s.ttf", name))
This looks copy+pasted from below in testScaling. Make this a helper function.

[nigeltao, 2013-10-10 20:29:13]

Your comments seem relatively minor, so I'll presume that it LGTY and will
submit. Let me know if you still have concerns.

https://codereview.appspot.com/14548046/diff/4001/freetype/truetype/truetype_...
File freetype/truetype/truetype_test.go (right):

https://codereview.appspot.com/14548046/diff/4001/freetype/truetype/truetype_...
freetype/truetype/truetype_test.go:79: "luxisr": map[rune]Index{
On 2013/10/10 11:46:32, bsiegert wrote:
> Can you omit the type name here?

Done.

https://codereview.appspot.com/14548046/diff/4001/freetype/truetype/truetype_...
freetype/truetype/truetype_test.go:159: b, err :=
ioutil.ReadFile(fmt.Sprintf("../../testdata/%s.ttf", name))
On 2013/10/10 11:46:32, bsiegert wrote:
> This looks copy+pasted from below in testScaling. Make this a helper function.

Done.

[nigeltao, 2013-10-10 20:29:52]

*** Submitted as
https://code.google.com/p/freetype-go/source/detail?r=10b39e74df10 ***

freetype/truetype: parse UCS-4 encoded cmap tables.

R=bsiegert
CC=golang-dev
https://codereview.appspot.com/14548046

[bsiegert, 2013-10-10 20:30:10]

Yes, LGTM.

-- 
The first essential in chemistry is that you should perform practical work
and conduct experiments, for he who performs not practical work nor makes
experiments will never attain the least degree of mastery.
        -- Abu Musa Jabir ibn Hayyan (721-815)