code review 14535048: go/build: add GOOS and GOARCH to name of gccgo pkg directory

go/build: add GOOS and GOARCH to name of gccgo pkg directory

This matches the behaviour of builder.includeArgs in
cmd/go/build.go.

[iant, 2013-10-11 15:50:32]

Hello golang-dev@googlegroups.com,

I'd like you to review this change to
https://code.google.com/p/go

[minux1, 2013-10-11 22:40:56]

https://codereview.appspot.com/14535048/diff/1/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

https://codereview.appspot.com/14535048/diff/1/src/pkg/go/build/build.go#newc...
src/pkg/go/build/build.go:448: pkga = "pkg/gccgo_" + ctxt.GOOS + "_" +
ctxt.GOARCH + "/" + dir + "lib" + elem + ".a"
should gccgo also support -installsuffix?

if it does, we can merge the gccgo and gc cases.

[iant, 2013-10-11 22:50:07]

https://codereview.appspot.com/14535048/diff/1/src/pkg/go/build/build.go
File src/pkg/go/build/build.go (right):

https://codereview.appspot.com/14535048/diff/1/src/pkg/go/build/build.go#newc...
src/pkg/go/build/build.go:448: pkga = "pkg/gccgo_" + ctxt.GOOS + "_" +
ctxt.GOARCH + "/" + dir + "lib" + elem + ".a"
On 2013/10/11 22:40:56, minux wrote:
> should gccgo also support -installsuffix?
> 
> if it does, we can merge the gccgo and gc cases.

Right now the -installsuffix option effectively selects a different standard
library.  The corresponding mechanism in GCC would be multilib, which does work
with gccgo (that's how the -m32 option works, for example).

I don't see a meaningful use for -installsuffix for gccgo in the 1.2 timeframe.

[minux1, 2013-10-11 23:08:07]

On Oct 11, 2013 6:50 PM, <iant@golang.org> wrote:
>
https://codereview.appspot.com/14535048/diff/1/src/pkg/go/build/build.go#newc...
> src/pkg/go/build/build.go:448: pkga = "pkg/gccgo_" + ctxt.GOOS + "_" +
> ctxt.GOARCH + "/" + dir + "lib" + elem + ".a"
> On 2013/10/11 22:40:56, minux wrote:
>>
>> should gccgo also support -installsuffix?
>
>> if it does, we can merge the gccgo and gc cases.
>
> Right now the -installsuffix option effectively selects a different
> standard library.  The corresponding mechanism in GCC would be multilib,
> which does work with gccgo (that's how the -m32 option works, for
> example).
>
> I don't see a meaningful use for -installsuffix for gccgo in the 1.2
> timeframe.
ok, i see.
LGTM.

[iant, 2013-10-11 23:17:47]

*** Submitted as https://code.google.com/p/go/source/detail?r=38739b63d028 ***

go/build: add GOOS and GOARCH to name of gccgo pkg directory

This matches the behaviour of builder.includeArgs in
cmd/go/build.go.

R=golang-dev, minux.ma
CC=golang-dev
https://codereview.appspot.com/14535048