Issue 14535046: code review 14535046: undo CL 14231047 / 2f4c2dde2756

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14535046: code review 14535046: undo CL 14231047 / 2f4c2dde2756 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 6 months ago by brainman

Modified:
10 years, 6 months ago

Reviewers:
rsc

CC:
golang-dev, rsc

Visibility:
Public.

Description

undo CL 14231047 / 2f4c2dde2756 undone because the change slows down profile collection significantly and unpredictable at times (see comments at https://codereview.appspot.com/14231047 for details) ««« original CL description runtime: collect profiles even while on g0 stack Fixes issue 6417 R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/14231047 »»»

Patch Set 1 #

Patch Set 2 : diff -r 52ce02a2718e https://go.googlecode.com/hg/ #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/pkg/runtime/os_windows.c	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

brainman

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

10 years, 6 months ago (2013-10-10 22:45:15 UTC) #1

brainman

I still do not have solution for original problem https://code.google.com/p/go/issues/detail?id=6417. I have also reopened https://code.google.com/p/go/issues/detail?id=6417, ...

10 years, 6 months ago (2013-10-10 22:45:41 UTC) #2

rsc

10 years, 6 months ago (2013-10-15 18:37:46 UTC) #4

*** Submitted as https://code.google.com/p/go/source/detail?r=87b01faee878 ***

undo CL 14231047 / 2f4c2dde2756

undone because the change slows down profile collection
significantly and unpredictable at times (see comments
at https://codereview.appspot.com/14231047 for details)

««« original CL description
runtime: collect profiles even while on g0 stack

Fixes issue 6417

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/14231047
»»»

R=golang-dev, rsc
CC=golang-dev
https://codereview.appspot.com/14535046

Committer: Russ Cox <rsc@golang.org>

Expand All Messages | Collapse All Messages