Issue 14531048: rpc: add notifications

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 14531048: rpc: add notifications

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 years, 7 months ago by rog

Modified:
10 years, 7 months ago

Reviewers:
axw, mp+190483

Visibility:
Public.

Description

rpc: add notifications This will allow us to selectively log rpc requests. https://code.launchpad.net/~rogpeppe/juju-core/447-rpc-log-filter/+merge/190483 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 6

Patch Set 2 : rpc: add notifications #

Patch Set 3 : rpc: add notifications #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+453 lines, -72 lines)			Patch
A	[revision details]	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	rpc/client.go	View		3 chunks	+12 lines, -0 lines	0 comments	Download
M	rpc/rpc_test.go	View		23 chunks	+355 lines, -49 lines	0 comments	Download
M	rpc/server.go	View	1 2	9 chunks	+82 lines, -21 lines	0 comments	Download
M	state/api/apiclient.go	View		1 chunk	+1 line, -1 line	0 comments	Download
M	state/apiserver/apiserver.go	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

axw

LGTM https://codereview.appspot.com/14531048/diff/1/rpc/server.go File rpc/server.go (right): https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode139 rpc/server.go:139: // as that cause delays to the RPC ...

10 years, 7 months ago (2013-10-11 07:30:17 UTC) #2

rog

10 years, 7 months ago (2013-10-11 09:17:42 UTC) #3

Please take a look.

https://codereview.appspot.com/14531048/diff/1/rpc/server.go
File rpc/server.go (right):

https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode139
rpc/server.go:139: // as that cause delays to the RPC server or deadlock.
On 2013/10/11 07:30:18, axw wrote:
> as that ____ cause?

Done.

https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode140
rpc/server.go:140: type RequestNotifier interface {
On 2013/10/11 07:30:18, axw wrote:
> Might be worthwhile adding a note that the methods must be goroutine-safe.

Done.

https://codereview.appspot.com/14531048/diff/1/rpc/server.go#newcode367
rpc/server.go:367: if conn.notifier != nil {
On 2013/10/11 07:30:18, axw wrote:
> Does this not want to be called regardless of whether the body was read?

Done.

Expand All Messages | Collapse All Messages