Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(504)

Issue 14531046: Adds tabview and readme to bundle detail view

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 7 months ago by jeff.pihach
Modified:
10 years, 7 months ago
Reviewers:
mp+189898, matthew.scott
Visibility:
Public.

Description

Adds tabview and readme to bundle detail view Clicking on the bundle token to display the bundle details now shows the details in a tabview. This branch also hooks up the 'readme' tab. https://code.launchpad.net/~hatch/juju-gui/bundle-detail-tabs/+merge/189898 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 4

Patch Set 2 : Adds tabview and readme to bundle detail view #

Patch Set 3 : Adds tabview and readme to bundle detail view #

Patch Set 4 : Adds tabview and readme to bundle detail view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1384 lines, -118 lines) Patch
A [revision details] View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M app/models/bundle.js View 1 1 chunk +10 lines, -0 lines 0 comments Download
M app/models/charm.js View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M app/store/charmworld.js View 1 chunk +4 lines, -3 lines 0 comments Download
M app/subapps/browser/browser.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M app/subapps/browser/templates/browser_charm.handlebars View 3 chunks +3 lines, -3 lines 0 comments Download
M app/subapps/browser/views/bundle.js View 1 2 3 4 chunks +23 lines, -3 lines 0 comments Download
M app/subapps/browser/views/charm.js View 1 2 3 1 chunk +2 lines, -6 lines 0 comments Download
M app/subapps/browser/views/entity-base.js View 1 5 chunks +82 lines, -50 lines 0 comments Download
M app/templates/bundle.handlebars View 2 chunks +8 lines, -14 lines 0 comments Download
M test/data/browserbundle.json View 1 1 chunk +1090 lines, -29 lines 0 comments Download
M test/index.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A test/test_bundle_details_view.js View 1 2 1 chunk +116 lines, -0 lines 0 comments Download
M test/test_charm_store.js View 1 chunk +15 lines, -0 lines 0 comments Download
M test/test_model.js View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M test/test_model_bundle.js View 1 2 2 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
10 years, 7 months ago (2013-10-08 15:54:54 UTC) #1
rharding
There's a missing test for the readme which should be copied from the charm version ...
10 years, 7 months ago (2013-10-08 16:40:39 UTC) #2
matthew.scott
LGTM https://codereview.appspot.com/14531046/diff/1/app/models/bundle.js File app/models/bundle.js (right): https://codereview.appspot.com/14531046/diff/1/app/models/bundle.js#newcode67 app/models/bundle.js:67: @default 'charm' @default 'bundle'?
10 years, 7 months ago (2013-10-08 16:41:01 UTC) #3
jeff.pihach
Please take a look.
10 years, 7 months ago (2013-10-08 22:10:24 UTC) #4
jeff.pihach
10 years, 7 months ago (2013-10-08 22:27:12 UTC) #5
*** Submitted:

Adds tabview and readme to bundle detail view

Clicking on the bundle token to display the bundle details
now shows the details in a tabview.

This branch also hooks up the 'readme' tab.

R=rharding, matthew.scott
CC=
https://codereview.appspot.com/14531046
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b